From owner-cvs-all Tue Jun 27 13:10:37 2000 Delivered-To: cvs-all@freebsd.org Received: from dt052n3e.san.rr.com (dt052n3e.san.rr.com [204.210.33.62]) by hub.freebsd.org (Postfix) with ESMTP id 2AFA837B6B7; Tue, 27 Jun 2000 13:10:35 -0700 (PDT) (envelope-from Doug@gorean.org) Received: from slave (doug@slave [10.0.0.1]) by dt052n3e.san.rr.com (8.9.3/8.9.3) with ESMTP id NAA26667; Tue, 27 Jun 2000 13:10:27 -0700 (PDT) (envelope-from Doug@gorean.org) Date: Tue, 27 Jun 2000 13:10:27 -0700 (PDT) From: Doug Barton X-Sender: doug@dt052n3e.san.rr.com To: Matthew Jacob Cc: Warner Losh , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/isp isp.c In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, 27 Jun 2000, Matthew Jacob wrote: > > Thanks! > > I hope it wasn't *too* big- I wanted to store all the info somewhere. Heck no. If anything, it would be nice if more people included more detail. Someone (I think it was Peter) recommended that commit messages should go into detail about _why_ something was done, and touch lightly on what was done since that info is available in the diff. I'm all in favor of anything that keeps me from having to go look the diff up, personally. Doug > On Tue, 27 Jun 2000, Warner Losh wrote: > > > In message <200006271944.MAA53998@freefall.freebsd.org> Matt Jacob writes: > > : Fix usage of DELAY (SYS_DELAY is the platform independent local > > : define). Fix stupidity wrt checking whether we've gone to > > : LOOP_PDB_RCVD loopstate- it's okay to be greater than this state. > > : D'oh! Protect calls to isp_pdb_sync and isp_fclink_state with IS_FC > > : macros. > > > > Excellent commit message. > > > > Warner > > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe cvs-all" in the body of the message > -- "Live free or die" - State motto of my ancestral homeland, New Hampshire Do YOU Yahoo!? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message