From owner-cvs-all Tue Jun 27 13:16: 0 2000 Delivered-To: cvs-all@freebsd.org Received: from gndrsh.dnsmgr.net (GndRsh.dnsmgr.net [198.145.92.4]) by hub.freebsd.org (Postfix) with ESMTP id 3B42C37B642; Tue, 27 Jun 2000 13:15:49 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.9.3/8.9.3) id NAA93048; Tue, 27 Jun 2000 13:15:23 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <200006272015.NAA93048@gndrsh.dnsmgr.net> Subject: Re: cvs commit: src/sys/dev/isp isp.c In-Reply-To: from Doug Barton at "Jun 27, 2000 01:10:27 pm" To: Doug@gorean.org (Doug Barton) Date: Tue, 27 Jun 2000 13:15:23 -0700 (PDT) Cc: mjacob@feral.com (Matthew Jacob), imp@village.org (Warner Losh), cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL54 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > On Tue, 27 Jun 2000, Matthew Jacob wrote: > > > > > Thanks! > > > > I hope it wasn't *too* big- I wanted to store all the info somewhere. > > Heck no. If anything, it would be nice if more people included > more detail. Someone (I think it was Peter) recommended that commit > messages should go into detail about _why_ something was done, and touch > lightly on what was done since that info is available in the diff. I'm all > in favor of anything that keeps me from having to go look the diff up, > personally. Which means things like ``Brucify'', ``Sheldonize'', and a handfull of other short one liner messages that tell nothing about what was done or why it was done should be grounds for hand slapping committers. A well written commit message is like a good picture, worth a 1000 words :-) -- Rod Grimes - KD7CAX @ CN85sl - (RWG25) rgrimes@gndrsh.dnsmgr.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message