From owner-freebsd-multimedia@FreeBSD.ORG  Wed Nov  2 19:29:30 2005
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
X-Original-To: freebsd-multimedia@freebsd.org
Delivered-To: freebsd-multimedia@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EC3F016A41F
	for <freebsd-multimedia@freebsd.org>;
	Wed,  2 Nov 2005 19:29:30 +0000 (GMT)
	(envelope-from julian@elischer.org)
Received: from a50.ironport.com (a50.ironport.com [63.251.108.112])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AD59943D48
	for <freebsd-multimedia@freebsd.org>;
	Wed,  2 Nov 2005 19:29:30 +0000 (GMT)
	(envelope-from julian@elischer.org)
Received: from unknown (HELO [10.251.23.117]) ([10.251.23.117])
	by a50.ironport.com with ESMTP; 02 Nov 2005 11:19:34 -0800
X-IronPort-Anti-Spam-Filtered: true
Message-ID: <43691146.7030404@elischer.org>
Date: Wed, 02 Nov 2005 11:19:34 -0800
From: Julian Elischer <julian@elischer.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.7.11) Gecko/20050727
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Kazuhito HONDA <kazuhito@ph.noda.tus.ac.jp>
References: <20051027133448.vptim01kwoco8wcw@netchild.homeip.net>	<20051028.224049.343190967.kazuhito@ph.noda.tus.ac.jp>	<20051029094831.1c6c785d.skywizard@MyBSD.org.my>
	<20051102.231412.343190544.kazuhito@ph.noda.tus.ac.jp>
In-Reply-To: <20051102.231412.343190544.kazuhito@ph.noda.tus.ac.jp>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-multimedia@freebsd.org, Alexander@Leidinger.net,
	skywizard@MyBSD.org.my
Subject: Re: uaudio and Digigram UAX220
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Nov 2005 19:29:31 -0000

Kazuhito HONDA wrote:

>From: Ariff Abdullah <skywizard@MyBSD.org.my>
>Subject: Re: uaudio and Digigram UAX220
>Date: Sat, 29 Oct 2005 09:48:31 +0800
>
>  
>
>>Could you please do the cleanup? :) The only thing is that Julian
>>already said that those patch break his USB microphone, so this must
>>undergo some serious regression test to be accepted.
>>    
>>


I'll try it on my microphone again tonight.

>
>Oh, I missed that.  I wonder why it isn't committed.
>I have searched the patch and found one problem.
>
>In uaudio_query_formats() of uaudio.c
>+
>+		if ( numchan != 1 && numchan == 2 )
>+
>+		foundcount++;
>+
>
>`foundcount' is a flag to indicate which a valid format is found or not.
>`numchan' is a number of channel.  
>If a device has mono channels only, foundcont flag isn't changed.
>I guess that it broke Julian's USB microphone, 
>because microphone is usually mono.
>  
>