From owner-freebsd-ports@FreeBSD.ORG  Sat May 17 05:36:22 2003
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2893337B401
	for <ports@FreeBSD.org>; Sat, 17 May 2003 05:36:22 -0700 (PDT)
Received: from mta06-svc.ntlworld.com (mta06-svc.ntlworld.com [62.253.162.46])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 28E8743F93
	for <ports@FreeBSD.org>; Sat, 17 May 2003 05:36:21 -0700 (PDT)
	(envelope-from jon@witchspace.com)
Received: from witchspace.com ([80.3.251.242]) by mta06-svc.ntlworld.com
          (InterMail vM.4.01.03.37 201-229-121-137-20020806) with SMTP
          id <20030517123619.KCUC12018.mta06-svc.ntlworld.com@witchspace.com>
          for <ports@FreeBSD.org>; Sat, 17 May 2003 13:36:19 +0100
Received: (qmail 86289 invoked from network); 17 May 2003 12:36:19 -0000
Received: from unknown (HELO witchspace.com) (192.168.0.1)
  by dookie.witchspace.com with SMTP; 17 May 2003 12:36:19 -0000
Message-ID: <3EC62CC2.6090209@witchspace.com>
Date: Sat, 17 May 2003 13:36:18 +0100
From: Jonathan Belson <jon@witchspace.com>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3.1) Gecko/20030509
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Kris Kennaway <kris@obsecurity.org>
References: <3EC53C6C.1040904@witchspace.com>
	<20030517121908.GA67369@rot13.obsecurity.org>
In-Reply-To: <20030517121908.GA67369@rot13.obsecurity.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: ports@FreeBSD.org
Subject: Re: FreeBSD Port: pornview-0.2.0.p.1
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 17 May 2003 12:36:22 -0000

Kris Kennaway wrote:
> The package builds currently fail on 4.x:
> 
> http://bento.freebsd.org/errorlogs/i386-4-latest/pornview-0.2.0.p.1_1.log
> 
> Your workaround does not sound like a solution though.  stdin et al
> are defined for a reason ;-)

The problem is in the following structure:

struct ChildContext_Tag
{
	...blah...
     int     stdout_fd;
     int     stderr_fd;
     int     stdin_fd;
	...blah...
};

The author's (perfectly legitimate) members are being mangled by
the preprocessor.  It seems a little unfair to ask the author to
change them, the only other alternative I can see is to s/// every
reference to something that doesn't clash with the FreeBSD stdio.h.

Ugly :-(


--Jon

http://www.witchspace.com