From owner-freebsd-hackers Mon Sep 3 10:18:44 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138]) by hub.freebsd.org (Postfix) with ESMTP id 5151737B409 for ; Mon, 3 Sep 2001 10:18:41 -0700 (PDT) Received: by bazooka.unixfreak.org (Postfix, from userid 1000) id DEE713E31; Mon, 3 Sep 2001 10:18:40 -0700 (PDT) Received: from bazooka.unixfreak.org (localhost [127.0.0.1]) by bazooka.unixfreak.org (Postfix) with ESMTP id D45073C12D for ; Mon, 3 Sep 2001 10:18:40 -0700 (PDT) To: hackers@freebsd.org Subject: Outdated comment in namei.h Date: Mon, 03 Sep 2001 10:18:35 -0700 From: Dima Dorfman Message-Id: <20010903171840.DEE713E31@bazooka.unixfreak.org> Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG The following is from namei.h, around line 116 in -current (r1.30): /* * Namei parameter descriptors. * * SAVENAME may be set by either the callers of namei or by VOP_LOOKUP. * If the caller of namei sets the flag (for example execve wants to * know the name of the program that is being executed), then it must * free the buffer. If VOP_LOOKUP sets the flag, then the buffer must >>>> * be freed by either the commit routine or the VOP_ABORT routine. * SAVESTART is set only by the callers of namei. It implies SAVENAME * plus the addition of saving the parent directory that contains the * name in ni_startdir. It allows repeated calls to lookup for the * name being sought. The caller is responsible for releasing the * buffer and for vrele'ing ni_startdir. */ The line marked refers to VOP_ABORT, which doesn't exist. It probably means VOP_ABORTOP, but that was removed two years ago. Anybody care to update this comment, or suggest what to write instead of that sentence? Would s/VOP_ABORT/NDFREE/ do it? Thanks. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message