From owner-freebsd-stable  Sun Oct 13  8:41: 1 2002
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5E8C337B401; Sun, 13 Oct 2002 08:40:59 -0700 (PDT)
Received: from fafoe.dyndns.org (chello212186121237.14.vie.surfer.at [212.186.121.237])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7D12243E9E; Sun, 13 Oct 2002 08:40:58 -0700 (PDT)
	(envelope-from stefan@fafoe.dyndns.org)
Received: by frog.fafoe (Postfix, from userid 1001)
	id D4BA51E3; Sun, 13 Oct 2002 17:40:55 +0200 (CEST)
Date: Sun, 13 Oct 2002 17:40:55 +0200
From: Stefan Farfeleder <e0026813@stud3.tuwien.ac.at>
To: Dmitry Morozovsky <marck@rinet.ru>
Cc: Kelly Yancey <kbyanc@FreeBSD.ORG>, stable@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/kern vfs_subr.c
Message-ID: <20021013154055.GA265@frog.fafoe>
References: <20021013191641.R1640-100000@woozle.rinet.ru> <20021013192019.Y1640-100000@woozle.rinet.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20021013192019.Y1640-100000@woozle.rinet.ru>
User-Agent: Mutt/1.5.1i
Sender: owner-freebsd-stable@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-stable.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-stable>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-stable>
X-Loop: FreeBSD.ORG

On Sun, Oct 13, 2002 at 07:22:17PM +0400, Dmitry Morozovsky wrote:
> On Sun, 13 Oct 2002, Dmitry Morozovsky wrote:
> 
> DM> On Sun, 13 Oct 2002, Kelly Yancey wrote:
> DM>
> DM> KY> kbyanc      2002/10/13 00:38:41 PDT
> DM> KY>
> DM> KY>   Modified files:        (Branch: RELENG_4)
> DM> KY>     sys/kern             vfs_subr.c
> DM> KY>   Log:
> DM> KY>   Use <sys/queue.h> macros rather than fondling implementation details.
> DM>
> DM> Kelly, it seems this commit broke -stable (see PR/44007)
> 
> ... and I can confirm that backing out this change revert -stable to working
> 
> (patch for band-aiding follows)
> 
> Index: sys/kern/vfs_subr.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/kern/vfs_subr.c,v
> retrieving revision 1.249.2.28
> diff -u -r1.249.2.28 vfs_subr.c
> --- sys/kern/vfs_subr.c 13 Oct 2002 07:38:41 -0000      1.249.2.28
> +++ sys/kern/vfs_subr.c 13 Oct 2002 15:17:55 -0000
> @@ -1256,7 +1256,7 @@
>         KASSERT(bp->b_vp != NULL, ("pbrelvp: NULL"));
> 
>         /* XXX REMOVE ME */
> -       if (!TAILQ_NEXT(bp, b_vnbufs)) {
> +       if (bp->b_vnbufs.tqe_next != NULL) {
>                 panic(
>                     "relpbuf(): b_vp was probably reassignbuf()d %p %x",
>                     bp,
> 
> 

The line should probably read:

if (TAILQ_NEXT(bp, b_vnbufs) != NULL) {

Regards,
Stefan Farfeleder

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message