From owner-cvs-all@FreeBSD.ORG  Mon Jan 19 10:45:46 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A8B5316A4CE; Mon, 19 Jan 2004 10:45:46 -0800 (PST)
Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4B49543D3F; Mon, 19 Jan 2004 10:45:45 -0800 (PST)
	(envelope-from obrien@dragon.nuxi.com)
Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1])
	by dragon.nuxi.com (8.12.10/8.12.9) with ESMTP id i0JIjiip006528;
	Mon, 19 Jan 2004 10:45:44 -0800 (PST)
	(envelope-from obrien@dragon.nuxi.com)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.12.10/8.12.10/Submit) id i0JIjibM006527;
	Mon, 19 Jan 2004 10:45:44 -0800 (PST)
	(envelope-from obrien)
Date: Mon, 19 Jan 2004 10:45:44 -0800
From: "David O'Brien" <obrien@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Message-ID: <20040119184544.GB6433@dragon.nuxi.com>
References: <200401191544.i0JFib85052132@repoman.freebsd.org>
	<20040119163258.GB4722@dragon.nuxi.com>
	<359167705.1074533881@andromede.reaumur.absolight.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <359167705.1074533881@andromede.reaumur.absolight.net>
User-Agent: Mutt/1.4.1i
X-Operating-System: FreeBSD 5.2-CURRENT
Organization: The NUXI BSD Group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/mail/p5-Mail-SpamAssassin Makefile distinfo
	pkg-plist
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: obrien@FreeBSD.org
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Jan 2004 18:45:46 -0000

On Mon, Jan 19, 2004 at 05:38:01PM +0100, Mathieu Arnold wrote:
> +-le 19/01/2004 08:32 -0800, David O'Brien ?crivait :
> | On Mon, Jan 19, 2004 at 07:44:37AM -0800, Mathieu Arnold wrote:
> |> mat         2004/01/19 07:44:37 PST
> |> 
> |>   FreeBSD ports repository
> |> 
> |>   Modified files:
> |>     mail/p5-Mail-SpamAssassin Makefile distinfo pkg-plist 
> |>   Log:
> |>   Update to 2.62
> |>   Have the least thing possible between bsd.port.pre.mk and post.mk
> | 
> | Please back this out.  It is hard to read and find the dependencies.  The
> | Porter's handbook clearly documents where w/in a port's Makefile
> | {BUILD,RUN}_DEPENDS belong in the Makefile.
> 
> Do you really mean that every perl port that does this should be changed ?
> it's the first time someone tells me so.

Well, I guess that opens up a discussion then.  I don't use many "p5"
ports, but I certainly do use SpamAssassin daily.  So I hadn't noticed
that they go against the Porters Handbook and 'portlint'.  It is
important to keep things all in the proper section so a user like me can
know what dependencies there are.  Often I install dependencies from a
precompiled package before I add local patches to the "leaf" port that I
ultimately want installed.