From owner-freebsd-ports@FreeBSD.ORG  Sat May 17 06:05:53 2003
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EB0D537B404
	for <ports@FreeBSD.org>; Sat, 17 May 2003 06:05:53 -0700 (PDT)
Received: from falcon.midgard.homeip.net (h76n3fls20o913.telia.com
	[213.67.148.76])	by mx1.FreeBSD.org (Postfix) with SMTP id 77DCC43F75
	for <ports@FreeBSD.org>; Sat, 17 May 2003 06:05:51 -0700 (PDT)
	(envelope-from ertr1013@student.uu.se)
Received: (qmail 66798 invoked by uid 1001); 17 May 2003 13:05:49 -0000
Date: Sat, 17 May 2003 15:05:49 +0200
From: Erik Trulsson <ertr1013@student.uu.se>
To: Jonathan Belson <jon@witchspace.com>
Message-ID: <20030517130549.GA44928@falcon.midgard.homeip.net>
Mail-Followup-To: Jonathan Belson <jon@witchspace.com>,
	Kris Kennaway <kris@obsecurity.org>, ports@FreeBSD.org
References: <3EC53C6C.1040904@witchspace.com>
	<20030517121908.GA67369@rot13.obsecurity.org>
	<3EC62CC2.6090209@witchspace.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3EC62CC2.6090209@witchspace.com>
User-Agent: Mutt/1.5.4i
cc: ports@FreeBSD.org
cc: Kris Kennaway <kris@obsecurity.org>
Subject: Re: FreeBSD Port: pornview-0.2.0.p.1
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 17 May 2003 13:05:54 -0000

On Sat, May 17, 2003 at 01:36:18PM +0100, Jonathan Belson wrote:
> Kris Kennaway wrote:
> >The package builds currently fail on 4.x:
> >
> >http://bento.freebsd.org/errorlogs/i386-4-latest/pornview-0.2.0.p.1_1.log
> >
> >Your workaround does not sound like a solution though.  stdin et al
> >are defined for a reason ;-)
> 
> The problem is in the following structure:
> 
> struct ChildContext_Tag
> {
> 	...blah...
>     int     stdout_fd;
>     int     stderr_fd;
>     int     stdin_fd;

That part of the structure is not the problem.  The next part of this
structure is the problem.

    gchar   stdout[GTK_MPLAYER_BUF_SIZE];
    gint    stdout_size;
    gchar   stderr[GTK_MPLAYER_BUF_SIZE];
    gint    stderr_size;

This code is faulty since stdin/stdout/stderr *are* macros and
therefore *will* mess up this declaration.

> 	...blah...
> };
> 
> The author's (perfectly legitimate) members are being mangled by

Not legitimate. The C standard itself says that stdin/stdout/stderr are
supposed to be macros and therefore this behaviour is expected.

> the preprocessor.  It seems a little unfair to ask the author to
> change them, the only other alternative I can see is to s/// every

The bug is in the application, not in FreeBSD, so, unfair or not, it
isn't FreeBSD that should be changed.

> reference to something that doesn't clash with the FreeBSD stdio.h.
> 
> Ugly :-(
> 
> 
> --Jon
> 
> http://www.witchspace.com
> 
> _______________________________________________
> freebsd-ports@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org"

-- 
<Insert your favourite quote here.>
Erik Trulsson
ertr1013@student.uu.se