From owner-cvs-all  Tue Sep 24  5: 5:46 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id DE3AE37B401; Tue, 24 Sep 2002 05:05:44 -0700 (PDT)
Received: from smtp0.adl1.internode.on.net (smtp0.adl1.internode.on.net [203.16.214.194])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id CF68843E42; Tue, 24 Sep 2002 05:05:43 -0700 (PDT)
	(envelope-from smckay@internode.on.net)
Received: from dungeon.home (ppp1477.qld.padsl.internode.on.net [150.101.178.196])
	by smtp0.adl1.internode.on.net (8.12.4/8.12.4) with ESMTP id g8OC5Up5081717;
	Tue, 24 Sep 2002 21:35:30 +0930 (CST)
Received: from dungeon.home (localhost [127.0.0.1])
	by dungeon.home (8.11.6/8.11.6) with ESMTP id g8OC5T810606;
	Tue, 24 Sep 2002 22:05:29 +1000 (EST)
	(envelope-from mckay)
Message-Id: <200209241205.g8OC5T810606@dungeon.home>
To: Mikhail Teterin <mi+mx@aldan.algebra.com>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	Stephen McKay <smckay@internode.on.net>
Subject: Re: cvs commit: src/bin/cp cp.c 
References: <200209221115.g8MBFv00023063@freefall.freebsd.org> <200209231428.06798.mi+mx@aldan.algebra.com>
In-Reply-To: <200209231428.06798.mi+mx@aldan.algebra.com>
    from Mikhail Teterin at "Mon, 23 Sep 2002 14:28:06 -0400"
Date: Tue, 24 Sep 2002 22:05:29 +1000
From: Stephen McKay <smckay@internode.on.net>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Monday, 23rd September 2002, Mikhail Teterin wrote:

>On Sunday 22 September 2002 07:15 am, Stephen McKay wrote:
>> mckay       2002/09/22 04:15:57 PDT
>> 
>>   Modified files:
>>     bin/cp               cp.c 
>>   Log:
>>   cp -p could report success even if a file copy failed. This was
>>   due to the cumulative exit status being overwritten when directory
>>   permissions were being set. This was particularly bad when called
>>   from mv(1) to perform a cross-device move as the original files were
>>   deleted even if the copy failed.
>
>It could also report failure -- from changing the timestamps and such,
>even though the file was copied. It, probably, still should report the
>problem, but the message the user sees should be more detailed.

Failure in utimes() is still a failure.  Errors show which system call
failed and I think that's enough.  But if you submit a PR with a patch
to improve error messages I'm sure it will be considered.

>What about MFC-ing?

Just received RE approval.

Stephen.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message