From owner-svn-ports-head@FreeBSD.ORG Sun Jan 26 19:18:45 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 594FE2C5; Sun, 26 Jan 2014 19:18:45 +0000 (UTC) Received: from mail-gg0-x232.google.com (mail-gg0-x232.google.com [IPv6:2607:f8b0:4002:c02::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BDE7A125A; Sun, 26 Jan 2014 19:18:44 +0000 (UTC) Received: by mail-gg0-f178.google.com with SMTP id q2so1943440ggc.9 for ; Sun, 26 Jan 2014 11:18:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:organization:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type; bh=f01dPCkc5tJxrMDTIBaaCf2pZDRf9bVQmyD/tktK2Rk=; b=0KqZOl+GZkQjCTCLah/fHWqQPRnLwQMEWXWGidkFgcte5r3NSwEkVc7yYk4c3Nr4Hm +EyDIY4KV0BQ0HNjdYg8fRjw7OPAyDGDjZZz9aZ1BimpU4yEu28XRBuB3vLPTZI6NUkt tGbEj5/i4chrorCsqvbSfu0Hh3BEgpxvYIdPkWgEEdeBKRI2K5s6m2e/+QzR7eM9gK8u IFc4xswX6tPaebGvSbZFrZmSqV/JlX89JyFR6jaHvIxwsP+37GZhvyE0Gw/onF0no9i+ rHwr6BatwRhzmqPMwcMeEJYqAdGZh09mmn0QZCQgJ9tdpSJI6dKsng2YQ1LHGCeFa3AD tvHQ== X-Received: by 10.236.134.46 with SMTP id r34mr64389yhi.62.1390763923969; Sun, 26 Jan 2014 11:18:43 -0800 (PST) Received: from [192.168.11.100] (189-46-65-10.dsl.telesp.net.br. [189.46.65.10]) by mx.google.com with ESMTPSA id 23sm26193303yhj.5.2014.01.26.11.18.40 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 26 Jan 2014 11:18:43 -0800 (PST) Sender: Renato Botelho Message-ID: <52E55F8F.2080305@FreeBSD.org> Date: Sun, 26 Jan 2014 17:18:39 -0200 From: Renato Botelho Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Andrej Zverev Subject: Re: svn commit: r341219 - in head/www: xpi-twitterfox xpi-unplug xpi-urllink xpi-user_agent_switcher xpi-vimperator References: <201401261514.s0QFEZY7093314@svn.freebsd.org> <52E54E98.8080307@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ifdJ2MOUKFxvXHIEbcjsIXdnPRi0O3Cbm" Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" , Martin Wilke X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jan 2014 19:18:45 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ifdJ2MOUKFxvXHIEbcjsIXdnPRi0O3Cbm Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 26-01-2014 17:14, Andrej Zverev wrote: > On Sun, Jan 26, 2014 at 10:06 PM, Renato Botelho wr= ote: >> On 26-01-2014 13:23, Andrej Zverev wrote: >>> On Sun, Jan 26, 2014 at 7:14 PM, Martin Wilke wrot= e: >>>> Author: miwi >>>> Date: Sun Jan 26 15:14:34 2014 >>>> New Revision: 341219 >>>> URL: http://svnweb.freebsd.org/changeset/ports/341219 >>>> QAT: https://qat.redports.org/buildarchive/r341219/ >>>> >>>> Log: >>>> - Stage support >>>> >>>> >>>> Modified: head/www/xpi-unplug/Makefile >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>>> --- head/www/xpi-unplug/Makefile Sun Jan 26 15:14:03 2014 = (r341218) >>>> +++ head/www/xpi-unplug/Makefile Sun Jan 26 15:14:34 2014 = (r341219) >>>> @@ -12,7 +12,6 @@ COMMENT=3D Converts embedded media to html >>>> XPI_ID=3D unplug@compunach >>>> XPI_NUM=3D 2254 >>>> >>>> -NO_STAGE=3D yes >>>> xpi-post-extract: >>>> ${FIND} ${WRKSRC} -type d -name CVS|${XARGS} ${RM} -rf >>>> >>>> >>>> Modified: head/www/xpi-urllink/Makefile >>> >>> >>> Can you at least run portlint and fix easy warnings in such commits? = like >>> "WARN: Makefile: [17]: possible use of "${FIND} ... ${XARGS} ${RM}" >>> when "${FIND} ... -delete" will work" >> >> find -delete won't delete a not empty directory. And this find is only= >> looking for directories. >=20 > While this is true, but distfile itself does not contain any CVS > directories in this case ;-) > 'easy fix' Now you have a good point :) --=20 Renato Botelho GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc --ifdJ2MOUKFxvXHIEbcjsIXdnPRi0O3Cbm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCgAGBQJS5V+PAAoJEPHw56GfYleQYCUP/iLfEWtQk3JiMBmNcSdnvX+D hLLjFP51pZnVOrebzv6lf+s04hubDQKM1lL0gOTwGQFIVDQMI93218NJXzoVhqqC Ws8s8qxlod0J7Gm2ndqojF5HnGb7J6hRU/8oj0T+xfgnddKQOJhuWsAXY4ZyNOf3 HhFgMWSfNdILEuELrYz+ynHR2T6WaJw69Hh5c7Whq+GK8y85MAgWkWJLjEnh4QHz Rpcv+/8TKUEGBHdj1hEVONk2RdD3mp1A1anLNQriRnc3THFeX03hsc8/2EgreCBk 2l4dltfiIH/0Z3hhoIewKjAGkIZJ97TZrjH8Qc2EY3xqaq7+dSnt9sYSKo5ouIlt cnEwC6wP82yCewObEC5wZKWm8NH7lMeZomoxImsQObc0M4MikMEBC2LFLW8zRBWj xKbCn9lLERn5xaOQ3lxRACcH7cN+Mdwl+6y8ZDP6l+iA5Toe6p9BUuvAKSk8VoEE e+K+6y6X9biVyyTcMFBB0QMVujSZhr2ZwJlidhy7QLm6w+GcWmlBaqsn5TF319zb ivXPSxjM0uKm+qY7gwQC42VlY+LoEkqBtewFR3KGp+PY/CchZjaGLYSkqVWVMYzM +xIXNxWZSCu5g0SXAEQuaGfBaGUBw87xK14H3ahctw3A2D+A/dpcU0bPR95OLgZQ kQI5o9XQogrW3RlyZYCn =0kBo -----END PGP SIGNATURE----- --ifdJ2MOUKFxvXHIEbcjsIXdnPRi0O3Cbm--