From owner-cvs-all@FreeBSD.ORG Sun Sep 2 09:59:35 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1955916A420; Sun, 2 Sep 2007 09:59:35 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0061713C48E; Sun, 2 Sep 2007 09:59:34 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l829xYQE077992; Sun, 2 Sep 2007 09:59:34 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l829xYGo077991; Sun, 2 Sep 2007 09:59:34 GMT (envelope-from rwatson) Message-Id: <200709020959.l829xYGo077991@repoman.freebsd.org> From: Robert Watson Date: Sun, 2 Sep 2007 09:59:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_sysctl.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Sep 2007 09:59:35 -0000 rwatson 2007-09-02 09:59:33 UTC FreeBSD src repository Modified files: sys/kern kern_sysctl.c Log: In userland_sysctl(), call useracc() with the actual newlen value to be used, rather than the one passed via 'req', which may not reflect a rewrite. This call to useracc() is redundant to validation performed by later copyin()/copyout() calls, so there isn't a security issue here, but this could technically lead to excessive validation of addresses if the length in newlen is shorter than req.newlen. Approved by: re (kensmith) Reviewed by: jhb Submitted by: Constantine A. Murenin Sponsored by: Google Summer of Code 2007 Revision Changes Path 1.177 +1 -1 src/sys/kern/kern_sysctl.c