From owner-freebsd-stable@FreeBSD.ORG Fri Nov 2 19:04:59 2012 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 310C7BBB; Fri, 2 Nov 2012 19:04:59 +0000 (UTC) (envelope-from b.smeelen@ose.nl) Received: from mail.ose.nl (mail.ose.nl [212.178.134.164]) by mx1.freebsd.org (Postfix) with ESMTP id 711348FC12; Fri, 2 Nov 2012 19:04:57 +0000 (UTC) X-Footer: b3NlLm5s Received: from localhost ([127.0.0.1]) by mail.ose.nl (using TLSv1/SSLv3 with cipher AES256-SHA (256 bits)); Fri, 2 Nov 2012 20:04:57 +0100 Message-ID: <50941958.7030108@ose.nl> Date: Fri, 02 Nov 2012 20:04:56 +0100 From: Bas Smeelen User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: Gary Palmer Subject: Re: [patch] Re: SU+J on 9.1-RC2 ISO References: <5093F934.7050306@ose.nl> <5093FD3D.3080201@ateamsystems.com> <1351876381.2657.1.camel@mjakubik.localdomain> <50940276.5030306@ateamsystems.com> <50940C20.3090409@ose.nl> <50940E40.3090709@ose.nl> <5094112C.2070102@ose.nl> <20121102184131.GB22755@dft-labs.eu> <20121102185929.GA24320@in-addr.com> In-Reply-To: <20121102185929.GA24320@in-addr.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable Cc: freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2012 19:04:59 -0000 On 11/02/2012 07=3A59 PM=2C Gary Palmer wrote=3A =3E On Fri=2C Nov 02=2C 2012 at 07=3A41=3A31PM +0100=2C Mateusz Guzik wrote= =3A =3E=3E On Fri=2C Nov 02=2C 2012 at 07=3A30=3A04PM +0100=2C Bas Smeelen wrot= e=3A =3E=3E=3E On 11/02/2012 07=3A17 PM=2C Bas Smeelen wrote=3A =3E=3E=3E=3E On 11/02/2012 07=3A08 PM=2C Bas Smeelen wrote=3A =3E=3E=3E=3E=3E On 11/02/2012 06=3A27 PM=2C Adam Strohl wrote=3A =3E=3E=3E=3E=3E=3E On 11/3/2012 0=3A13=2C Mike Jakubik wrote=3A =3E=3E=3E=3E=3E=3E=3E You can disable SU+J after installing=2C though it wo= uld be nice if the =3E=3E=3E=3E=3E=3E=3E installer gave you a choice=2E =3E=3E=3E=3E=3E=3E This assumes that you know about this flaw=2C which most= people do not=2E =3E=3E=3E=3E=3E=3E =3E=3E=3E=3E=3E=3E I didn=27t until I discovered it by panic-ing a perfectl= y fine running =3E=3E=3E=3E=3E=3E server=2E Getting burned by a known bug like this shoul= dn=27t be =22SOP=22 =3E=3E=3E=3E=3E=3E for users of FreeBSD=2E =3E=3E=3E=3E=3E=3E =3E=3E=3E=3E=3E=3E If anything it should be turned off by default=2C and pe= ople can turn it =3E=3E=3E=3E=3E=3E on if they want given the landmine it plants=2E If they= know how to =3E=3E=3E=3E=3E=3E turn it on they=27re much more likely to be aware of the= issue=2E =3E=3E=3E=3E=3E=3E =3E=3E=3E=3E=3E=3E =3E=3E=3E=3E=3E=3E =3E=3E=3E To sum it up =3E=3E=3E SU+J should be turned off by default because of =3E=3E=3E 1=2E It does not work with dumping a live system e=2Eg=2E snapsho= t =3E=3E=3E 2=2E it is not recommended for SSD installs =3E=3E=3E 3=2E =22Smart=22 admins can turn it on if they want =3E=3E=3E =3E=3E=3E root=40sys=3A/usr/src/usr=2Esbin/bsdinstall/partedit =23 diff -u= gpart=5Fops=2Ec =3E=3E=3E gpart=5Fops=2Ecnew =3E=3E=3E --- gpart=5Fops=2Ec 2012-08-06 01=3A54=3A33=2E000000000 +0200= =3E=3E=3E +++ gpart=5Fops=2Ecnew 2012-11-02 19=3A07=3A45=2E000000000 +01= 00 =3E=3E=3E =40=40 -90=2C8 +90=2C8 =40=40 =3E=3E=3E =7B=22SU=22=2C =22Softupdates=22=2C =3E=3E=3E =22Enable softupdates =28default=29=22=2C 1=20= =7D=2C =3E=3E=3E =7B=22SUJ=22=2C =22Softupdates journaling=22=2C =3E=3E=3E - =22Enable file system journaling =28default -=20= =22 =3E=3E=3E - =22turn off for SSDs=29=22=2C 1 =7D=2C =3E=3E=3E + =22Disable file system journaling =28default -= =22 =3E=3E=3E + =22turn on for adventurish admins=29=22=2C 0=20= =7D=2C =3E=3E=3E =7B=22TRIM=22=2C =22Enable SSD TRIM support=22=2C= =3E=3E=3E =22Enable TRIM support=2C useful on solid-stat= e drives=22=2C =3E=3E=3E 0 =7D=2C =3E=3E=3E =3E=3E=3E Please comment=2C then I can file a PR or not =3E=3E As was noted in my another mail=2C the kernel will no longer crash w= hen an =3E=3E attempt to take a snapshot is made=2E Also AFAIR SUJ can be disabled= =3E=3E later=2E =3E=3E =3E=3E Given that I prefer the following=3A =3E=3E =3E=3E diff --git a/usr=2Esbin/bsdinstall/partedit/gpart=5Fops=2Ec b/usr=2E= sbin/bsdinstall/partedit/gpart=5Fops=2Ec =3E=3E index 479365a=2E=2E80296c2 100644 =3E=3E --- a/usr=2Esbin/bsdinstall/partedit/gpart=5Fops=2Ec =3E=3E +++ b/usr=2Esbin/bsdinstall/partedit/gpart=5Fops=2Ec =3E=3E =40=40 -91=2C7 +91=2C7 =40=40 newfs=5Fcommand=28const char *fstype= =2C char *command=2C int use=5Fdefault=29 =3E=3E =09=09=09 =22Enable softupdates =28default=29=22=2C 1 =7D=2C =3E=3E =09=09=09=7B=22SUJ=22=2C =22Softupdates journaling=22=2C =3E=3E =09=09=09 =22Enable file system journaling =28default - =22 =3E=3E -=09=09=09 =22turn off for SSDs=29=22=2C 1 =7D=2C =3E=3E +=09=09=09 =22turn off for SSDs or if you use snapshots=29=22=2C= 1 =7D=2C =3E=3E =09=09=09=7B=22TRIM=22=2C =22Enable SSD TRIM support=22=2C =3E=3E =09=09=09 =22Enable TRIM support=2C useful on solid-state drive= s=22=2C =3E=3E =09=09=09 0 =7D=2C =3E=3E =3E=3E http=3A//people=2Efreebsd=2Eorg/=7Emjg/patches/suj-snapshot-comment= =2Ediff =3E How many people realise that snapshots are needed for dump based backup= s =3E =28and other related features=29=3F =3E =3E Gary My guess=3F A lot=2E But most who realize would turn SU+J off on new installs=2E I just ran across this when doing a new install from 9=2E1-RC2 and not=20= paying attention e=2Eg=2E realizing that SU+J is turned on by default now= =2E I have seen coming this across the mail lists before though=2E This e-mail message=2C including any attachment=28s=29=2C is intended solel= y for the addressee or addressees=2E Any views or opinions presented herein= are solely those of the author and do not necessarily represent those of O= SE=2E If you are not the intended recipient of this communication please return t= his e-mail message and the attachment=28s=29 to the sender and delete and d= estroy all copies=2E