From owner-svn-src-all@FreeBSD.ORG Tue Feb 12 19:37:20 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B69B5E45; Tue, 12 Feb 2013 19:37:20 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by mx1.freebsd.org (Postfix) with ESMTP id 9D477D2A; Tue, 12 Feb 2013 19:37:19 +0000 (UTC) Received: by mail-wg0-f48.google.com with SMTP id 16so359704wgi.27 for ; Tue, 12 Feb 2013 11:37:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=X+nwnN49YvB7aPyK++ETwseOZ66CiZNbCwL8v2wzgk8=; b=qV4YwnNzDH30aJdy/npXy3q5N5lzDmGeIXXUt4lBkVtbcIPP1V9IfaJd7tskQ78OpM Irv0I60gvO1JvGnwmu/67ZJCfStt0oCaMH2PEUb4twEUdWkLk3TNPpH7SCQQcwxh1/Pl bPGI+I4WKV7ZNcGOjLscTw1mqUcvk+e4qdhMUGoTyFsMhaJc20PQcFmHDisFgfAY0f6U lrwu9vD5XjcZFbV4ssjAX4DlYpV1eRkfqedr9aSfCB3oV7vB4uw3bkdOba0Yn4Hphxl3 TdP+Mj2x2bVOtBRIyxX5/Y9dAWXDNApeZOcsfiDDJutd/J4LrIbTkqtgsSRFMIbjRil3 QutQ== MIME-Version: 1.0 X-Received: by 10.180.85.8 with SMTP id d8mr5568792wiz.4.1360697832944; Tue, 12 Feb 2013 11:37:12 -0800 (PST) Sender: pluknet@gmail.com Received: by 10.195.12.163 with HTTP; Tue, 12 Feb 2013 11:37:12 -0800 (PST) In-Reply-To: <201302121910.r1CJAsvE050091@svn.freebsd.org> References: <201302121910.r1CJAsvE050091@svn.freebsd.org> Date: Tue, 12 Feb 2013 22:37:12 +0300 X-Google-Sender-Auth: TloH2UA7q9ZO_bQL01whR8HiP-c Message-ID: Subject: Re: svn commit: r246720 - head/usr.bin/kdump From: Sergey Kandaurov To: Andrey Zonov Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2013 19:37:20 -0000 On 12 February 2013 23:10, Andrey Zonov wrote: > Author: zont > Date: Tue Feb 12 19:10:54 2013 > New Revision: 246720 > URL: http://svnweb.freebsd.org/changeset/base/246720 > > Log: > - Make actually printing path of AF_LOCAL socket types. > > MFC after: 1 week > > Modified: > head/usr.bin/kdump/kdump.c > > Modified: head/usr.bin/kdump/kdump.c > ============================================================================== > --- head/usr.bin/kdump/kdump.c Tue Feb 12 18:48:11 2013 (r246719) > +++ head/usr.bin/kdump/kdump.c Tue Feb 12 19:10:54 2013 (r246720) > @@ -1492,7 +1492,6 @@ ktrsockaddr(struct sockaddr *sa) > > memset(&sa_un, 0, sizeof(sa_un)); > memcpy(&sa_un, sa, sa->sa_len); > - check_sockaddr_len(un); > printf("%.*s", (int)sizeof(sa_un.sun_path), sa_un.sun_path); > break; > } > @@ -1616,8 +1615,7 @@ ktrstruct(char *buf, size_t buflen) > if (datalen > sizeof(ss)) > goto invalid; > memcpy(&ss, data, datalen); > - if (datalen < sizeof(struct sockaddr) || > - datalen != ss.ss_len) > + if (datalen != ss.ss_len) > goto invalid; > ktrsockaddr((struct sockaddr *)&ss); > } else { Thanks. For the record, before: 6436 id CALL connect(0x3,0x7fffffffd630,0x14) 6436 id STRU struct sockaddr { AF_LOCAL, invalid } 6436 id NAMI "/var/run/nslcd.ctl" 6436 id RET connect 0 After: 6436 id CALL connect(0x3,0x7fffffffd630,0x14) 6436 id STRU struct sockaddr { AF_LOCAL, /var/run/nslcd.ctl } 6436 id NAMI "/var/run/nslcd.ctl" 6436 id RET connect 0 -- wbr, pluknet