From owner-freebsd-stable Sun Oct 13 8:55:26 2002 Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7FEE337B401; Sun, 13 Oct 2002 08:55:25 -0700 (PDT) Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 49A9643E88; Sun, 13 Oct 2002 08:55:23 -0700 (PDT) (envelope-from marck@rinet.ru) Received: from localhost (localhost [127.0.0.1]) by woozle.rinet.ru (8.12.5/8.12.5) with ESMTP id g9DFtKTJ028811; Sun, 13 Oct 2002 19:55:20 +0400 (MSD) (envelope-from marck@rinet.ru) Date: Sun, 13 Oct 2002 19:55:20 +0400 (MSD) From: Dmitry Morozovsky To: Stefan Farfeleder Cc: Kelly Yancey , Subject: Re: cvs commit: src/sys/kern vfs_subr.c In-Reply-To: <20021013154055.GA265@frog.fafoe> Message-ID: <20021013195252.M1640-100000@woozle.rinet.ru> X-NCC-RegID: ru.rinet MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 13 Oct 2002, Stefan Farfeleder wrote: SF> > - if (!TAILQ_NEXT(bp, b_vnbufs)) { SF> > + if (bp->b_vnbufs.tqe_next != NULL) { SF> SF> The line should probably read: SF> SF> if (TAILQ_NEXT(bp, b_vnbufs) != NULL) { ... or simply if (TAILQ_NEXT(bp, b_vnbufs)) { but i'm afraid it's against style(9) BTW, this commit together with one or two more are *NOT* MFC instead of other sys/queue commits. And, I suppose, this would be the source of our troubles. ;-) Sincerely, D.Marck [DM5020, DM268-RIPE, DM3-RIPN] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message