From owner-svn-src-all@FreeBSD.ORG  Wed Mar 16 00:45:06 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2EB6D106566B;
	Wed, 16 Mar 2011 00:45:06 +0000 (UTC)
	(envelope-from mdounin@mdounin.ru)
Received: from mdounin.cust.ramtel.ru (mdounin.cust.ramtel.ru [81.19.69.81])
	by mx1.freebsd.org (Postfix) with ESMTP id D80D08FC20;
	Wed, 16 Mar 2011 00:45:05 +0000 (UTC)
Received: from mdounin.ru (mdounin.cust.ramtel.ru [81.19.69.81])
	by mdounin.cust.ramtel.ru (Postfix) with ESMTP id 42E4817024;
	Wed, 16 Mar 2011 03:45:04 +0300 (MSK)
Date: Wed, 16 Mar 2011 03:45:04 +0300
From: Maxim Dounin <mdounin@mdounin.ru>
To: Jung-uk Kim <jkim@FreeBSD.org>
Message-ID: <20110316004503.GM99496@mdounin.ru>
References: <201103152145.p2FLjAlt060256@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201103152145.p2FLjAlt060256@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r219679 - head/sys/i386/include
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Mar 2011 00:45:06 -0000

Hello!

On Tue, Mar 15, 2011 at 09:45:10PM +0000, Jung-uk Kim wrote:

> Author: jkim
> Date: Tue Mar 15 21:45:10 2011
> New Revision: 219679
> URL: http://svn.freebsd.org/changeset/base/219679
> 
> Log:
>   Partially revert r219672.  After r198295, kernel need to seed randomness as
>   soon as possible for stack protector.  However, dummy timecounter does not

Not after, long before and not only for stack protector.  The 
r198295 somewhat fixes things to actually make some randomness 
available early.

>   have enough entropy and we don't need to sacrifice Pentium class and later.
>   
>   Pointed out by:	Maxim Dounin (mdounin at mdounin dot ru)
> 
> Modified:
>   head/sys/i386/include/cpu.h
> 
> Modified: head/sys/i386/include/cpu.h
> ==============================================================================
> --- head/sys/i386/include/cpu.h	Tue Mar 15 21:34:10 2011	(r219678)
> +++ head/sys/i386/include/cpu.h	Tue Mar 15 21:45:10 2011	(r219679)
> @@ -69,10 +69,14 @@ void	swi_vm(void *);
>  static __inline uint64_t
>  get_cyclecount(void)
>  {
> +#if defined(I486_CPU) || defined(KLD_MODULE)
>  	struct bintime bt;
>  
>  	binuptime(&bt);
>  	return ((uint64_t)bt.sec << 56 | bt.frac >> 8);
> +#else
> +	return (rdtsc());
> +#endif

This isn't really different as long as GENERIC kernel used, as 
GENERIC defines I486_CPU.

Maxim Dounin

>  }
>  
>  #endif
> _______________________________________________
> svn-src-all@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"