From owner-svn-src-stable-10@FreeBSD.ORG Fri Oct 10 15:59:24 2014 Return-Path: Delivered-To: svn-src-stable-10@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B06F983B for ; Fri, 10 Oct 2014 15:59:24 +0000 (UTC) Received: from mail-la0-f47.google.com (mail-la0-f47.google.com [209.85.215.47]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0C679C6E for ; Fri, 10 Oct 2014 15:59:23 +0000 (UTC) Received: by mail-la0-f47.google.com with SMTP id pv20so3587052lab.34 for ; Fri, 10 Oct 2014 08:59:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type; bh=yFh6pPvGLeF16VvQghOMXHUBnAKX6wzrSS0gPI8GkjI=; b=AUdfM1tq0UGMKaso9ZX+nH+Wtm+2O+8a8E4Zx0irqpIxiRYBKW38lnZz8yBNN1N1JF Le0o8e3acLcOoRv6/xCe9Fc9Sul7WZGgt8vKUvEQPs0MCLgmqsnjscNaMAlhh0zoESoC 7BkqlSmiSkmDjKFAxr99HDQOOx8lKDGE6Y0fkbAwqYiPO/LknH90tlAFELIty4POOjSP LVwGrmk2vOn9HamII4qdLbq9SJDeWnKfr9ATGdsmrlZpd8kOmKKJszEBnLKM9pasUq1p 2q6GvAMweN+Bg1O701SLt+PWFbFEtIEKqhIQaRXrH0TbVrWndXDVLnkQ9lXhw22jYzcX GKzA== X-Gm-Message-State: ALoCoQkQH6rSSabZVEELOuZDXmETLzfsaexpSyXc6jmdNd8TIWu+phXtNghTFvn52sqLvpTu4/eH X-Received: by 10.152.36.130 with SMTP id q2mr6090275laj.42.1412956758026; Fri, 10 Oct 2014 08:59:18 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by mx.google.com with ESMTPSA id k3sm1931443lam.33.2014.10.10.08.59.16 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Oct 2014 08:59:16 -0700 (PDT) Message-ID: <54380254.3090702@freebsd.org> Date: Fri, 10 Oct 2014 19:59:16 +0400 From: Andrey Chernov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Hiroki Sato Subject: Re: svn commit: r270122 - in stable/10: . lib/libopie References: <201408180242.s7I2gNaq087095@svn.freebsd.org> <20141010144747.GH19486@ivaldir.etoilebsd.net> <5437F373.1090300@freebsd.org> <20141011.000201.1863876266089528066.hrs@allbsd.org> <5437F71E.1090701@freebsd.org> <5437F8A0.4080905@freebsd.org> In-Reply-To: <5437F8A0.4080905@freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="C4bHrobAT0LTejDQChRd22UTOmDX8GPxO" Cc: svn-src-stable@freebsd.org, bapt@FreeBSD.org, src-committers@freebsd.org, svn-src-stable-10@freebsd.org, svn-src-all@freebsd.org X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Oct 2014 15:59:24 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --C4bHrobAT0LTejDQChRd22UTOmDX8GPxO Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: quoted-printable On 10.10.2014 19:17, Andrey Chernov wrote: > On 10.10.2014 19:11, Andrey Chernov wrote: >> On 10.10.2014 19:02, Hiroki Sato wrote: >>> ac> It is strange that nobody notice that so far. Is there any packag= es >>> ac> which builds with libopie? If no, there is no problem. If yes, wh= at you >>> >>> cyrus-sasl uses it. >>> >>> ac> suggest to fix, is that backing out? If yes, when exactly this ch= ange >>> ac> can be merged to -stable (because -stable always stays -stable, s= o from >>> ac> your sentence it means - never can be merged). >>> >>> Is it impossible to handle this by symbol versioning instead of shli= b >>> version bump? >> >> There is buffer size #define change (it was too small in unfixed >> version, so discards valid input), the buffer itself is in the userlan= d >> programs, not in the library. AFAIK symbol versioning is for functions= , >> not for such changes but I can be wrong, I know very little about symb= ol >> versioning procedure. >=20 > From other hand, the check for buffer size is in the library, so the > function which does the check can be versioned, but I still don't know > how exactly to do that. >=20 It does not help in general case. Such checks can be in the userland too. So, backing out buffer size change and major version bump for -stable, right? --=20 http://ache.vniz.net/ --C4bHrobAT0LTejDQChRd22UTOmDX8GPxO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJUOAJVAAoJEKUckv0MjfbK77gIAI7cGviTYNwTa4DbDRqk7Lnu kfKp2xbfzz8zSAkw16w0LsRbC0vGjN1CtOH6auy6D4C8gw0tgFRT50BVGbkzjNds Yx7Ir6McjJ3YOCE4Kl73ezoOALWYEyZh36rKvp3n7vTS4Ow6uuSlulyuNlGJz1mX htrrTpvR5aVPTMrWMirBHCcop4b3sdsUCNrYrFQyf5FrA7d0pqD8Fvq+7s7RipNC S9onp7nH/5prp/5F/NvQKfHH00FiPqlDzCFnH06E5hml4EF0sNPruyZENXJIijk2 kJt79UZxkm2+ddKDflyCrAGYiJNjq/N4h/YHed5bKjsSI4Dt2DrxwuUlPdFSizM= =es/J -----END PGP SIGNATURE----- --C4bHrobAT0LTejDQChRd22UTOmDX8GPxO--