From owner-freebsd-ports@FreeBSD.ORG Thu May 17 20:29:53 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9CC8F10656D0 for ; Thu, 17 May 2012 20:29:53 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 18F898FC08 for ; Thu, 17 May 2012 20:29:52 +0000 (UTC) Received: by bkvi18 with SMTP id i18so2521360bkv.13 for ; Thu, 17 May 2012 13:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=LolysqBk3FGa4tMLXRfDoNZoTeejdbmsvtIgozoPVgg=; b=M/lTTzYZG+daz2dhAf5f9i3AnTn9aneq2tg/uizjbX0wgSRDrlGAQKXihYwPs4Hh/5 Qe0JRrF4faKa0MQyNQf+elyZQDw14SQEDemUNOG/0emrHM4pmImPtdKIu7rCjFamVBKx 86RvmPFd0LHyLRDr+0kPDFQDmHa6A1dmU68m6brFzrwiJIfNV7AcsVl+/eommCbfpn6t +ZgfE8FqowP4I48U7Xn3gTxEFczT0QtI1ku794xU5b/uXIGLK174H2xrEye2dCMnaFVL FG/wZm1+9aPoqCPyb+4W5mbt+mqsl40RALQFVhi3r+SLRVI12jE1b+Mnpr6Z6//ET0+X 8IUg== Received: by 10.205.33.136 with SMTP id so8mr2964026bkb.1.1337286591715; Thu, 17 May 2012 13:29:51 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.204.171.138 with HTTP; Thu, 17 May 2012 13:29:21 -0700 (PDT) In-Reply-To: References: From: Chris Rees Date: Thu, 17 May 2012 21:29:21 +0100 X-Google-Sender-Auth: YMzj0LKmM2B19mXe4AFi1zQcdEA Message-ID: To: =?ISO-8859-1?Q?Fernando_Apestegu=EDa?= Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-ports@freebsd.org Subject: Re: On file installation X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2012 20:29:53 -0000 On 17 May 2012 20:58, Fernando Apestegu=EDa = wrote: > On Tue, May 15, 2012 at 9:11 PM, Fernando Apestegu=EDa > wrote: >> On Tue, May 15, 2012 at 7:29 PM, Chris Rees wrote: >>> On 15 May 2012 18:14, Fernando Apestegu=EDa wrote: >>>> On Mon, May 14, 2012 at 7:40 PM, Fernando Apestegu=EDa >>>> wrote: >>>>> On Mon, May 14, 2012 at 7:31 PM, Chris Rees wrote= : >>>>>> On 14 May 2012 18:23, Fernando Apestegu=EDa wrote: >>>>>>> Hi, >>>>>>> >>>>>>> I'm working on a port for an application written in Java and I'm >>>>>>> having some problems deciding how to install the application. >>>>>>> Previous to the installation, the WRKSRC directory contains some .j= ar >>>>>>> files and some directories along with some .txt files for >>>>>>> licenses, but also some .exe and .bat files _which I don't want to >>>>>>> install_. It is basically a package that contains both files for >>>>>>> windows and non-windows systems. >>>>>>> >>>>>>> I was thinking on using COPYTREE_SHARE to install everything and th= en >>>>>>> remove the non necessary files, but doesn't look like >>>>>>> an elegant solution. Also, I wouldn't like to explicitly specify ev= ery >>>>>>> one of the files I want to copy. Is there a way of using something >>>>>>> similar to bash's extglob so I can copy !(*.exe|*bat)? If not, how = to proceed? >>>>>>> >>>>>>> I already looked at the existent ports to find something similar bu= t >>>>>>> it seems hard to find. I also had a look at bsd.port.mk but >>>>>>> I couldn't find what I'm looking for. >>>>>> >>>>>> You can use find primaries with COPYTREE_SHARE such as; >>>>>> >>>>>> (cd ${WRKSRC}/wherever && ${COPYTREE_SHARE} \* >>>>>> ${JAVALIBDIR}/${PORTNAME}/wherever "-not -name \*.exe -and -not -nam= e >>>>>> \*.bat" >>>>> >>>>> Thanks! I think that is what I was looking for :) >>>> >>>> Sorry guys, but I think I need more help :). I tried with the followin= g line: >>>> >>>> ( cd ${WRKSRC}/JDownloader && ${COPYTREE_SHARE} \* >>>> ${PREFIX}/${PORTNAME}/ "! -name \*.exe" ) >>>> >>>> but it doesn't seem to follow primaries and it still installs the .exe >>>> files. I just tried with: >>>> >>>> ( cd ${WRKSRC}/JDownloader && ${COPYTREE_SHARE} \* >>>> ${PREFIX}/${PORTNAME}/ "! -name JDownloader.exe" ) >>>> >>>> and check that effectively the file is not installed so I suppose this >>>> has something to do with quoting and escaping special characters (the >>>> asterisk). I found the following line in audio/xmp/Makefile: >>>> >>>> ( cd ${WRKSRC}/docs && ${COPYTREE_SHARE} \* \ >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0${DOCSDIR} '! ( -name Makefile -or -nam= e xmp.1 \ >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0-or -name *.bak -or -name *.orig )' ) >>>> >>>> that seems pretty close to what I'm trying to do, so I tried with this= : >>>> >>>> ( cd ${WRKSRC}/JDownloader && ${COPYTREE_SHARE} \* >>>> ${PREFIX}/${PORTNAME}/ '! ( -name *.exe )' ) >>>> >>>> but then, the asterisk is expanded and find fails: >>>> >>>> find: JDownloader.exe: unknown primary or operator >>>> >>>> what am I doing wrong? >>> >>> Escape the *; >>> >>> (cd ${WRKSRC}/JDownloader && ${COPYTREE_SHARE} \* ${PREFIX}/${PORTNAME}= / >>> =A0'! ( -name \*.exe )' ) >> >> That executes the following: >> >> (cd /usr/home/fernape/porting/jdownloader/port/work/JDownloader && >> /bin/sh -c '(/usr/bin/find -d $0 $2 | /usr/bin/cpio -dumpl $1 >>>/dev/null =A02>&1) && =A0/usr/sbin/chown -R root:wheel $1 && >> /usr/bin/find -d $0 $2 -type d -exec chmod 755 $1/{} \; && >> /usr/bin/find -d $0 $2 -type f -exec chmod 444 $1/{} \;' -- \* >> /usr/local/jdownloader/ '! ( -name \*.exe )' ) >> >> which results in: >> >> $ ls /usr/local/jdownloader >> >> JDUpdate.exe =A0 =A0 =A0 =A0 =A0 JDownloaderBETA.exe =A0 =A0jd/ >> license.txt =A0 =A0 =A0 =A0 =A0 =A0outdated.dat =A0 =A0 =A0 =A0 =A0 tool= s/ >> windows_restore.bat >> JDownloader.exe =A0 =A0 =A0 =A0JDownloaderD3D.exe =A0 =A0 jdupdate.jar >> license_german.txt =A0 =A0 plugins/ =A0 =A0 =A0 =A0 =A0 =A0 =A0 version.= txt >> JDownloader.jar =A0 =A0 =A0 =A0java/ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= libs/ >> licenses/ =A0 =A0 =A0 =A0 =A0 =A0 =A0tmp/ =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 windows_createlog.bat >> >> The .exe files are still there. > > Sorry or my insistence :) > > This is what I have in my Makefile: > > =A0 =A0 =A0 =A0( cd ${WRKSRC}/JDownloader && ${COPYTREE_SHARE} \* \ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0${PREFIX}/${PORTNAME} = '! ( -name *.exe -or -name *.dll \ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0-or -name *.bat )' ) > > what I've observed is that 'make install' fails with this message: > > find: JDownloader.exe: unknown primary or operator > find: JDownloader.exe: unknown primary or operator > > However, if I replace the expression so I filter with something like > *.txt and there is only > one file in the directory, it works. I checked this with audio/xmp > > $cat Makefile > ... > .if !defined(NOPORTDOCS) > =A0 =A0 =A0 =A0${ECHO_MSG} Installing documentation in ${DOCSDIR} > =A0 =A0 =A0 =A0( cd ${WRKSRC}/docs && ${COPYTREE_SHARE} \* \ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0${DOCSDIR} '! ( -name Makefile -or -name x= mp.1 \ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0-or -name *.bak -or -name *.orig )' ) > .endif > > ... > > $ make > > $ ls work/xmp-3.5.0/docs/*.bak > work/xmp-3.5.0/docs/xmp.1.bak > > Only one file (make install works fine). > > $ touch work/xmp-3.5.0/docs/test.bak > > $make install > > =3D=3D=3D> =A0Installing for xmp-3.5.0,1 > =3D=3D=3D> =A0 xmp-3.5.0,1 depends on file: /usr/local/bin/unzip - found > =3D=3D=3D> =A0 Generating temporary packing list > =3D=3D=3D> =A0Checking if audio/xmp already installed > Installing xmp in /usr/local/bin > Installing xmp.conf in /usr/local/etc/xmp > Installing modules.conf in /usr/local/etc/xmp > Installing manpages in /usr/local/man/man1 > > =A0Installation complete. To customize, copy /usr/local/etc/xmp/xmp.conf > =A0and /usr/local/etc/xmp/modules.conf to $HOME/.xmp/ > > Installing documentation in /usr/local/share/doc/xmp > find: xmp.1.bak: unknown primary or operator > chown: /usr/local/share/doc/xmp: No such file or directory > *** Error code 1 > > Stop in /usr/ports/audio/xmp. > *** Error code 1 > > Stop in /usr/ports/audio/xmp. > > > Why is this? > > Thanks in advances OK, you got me curious enough to get testing. The problem is that the -name *.bak expands to -name test.bak xmp1.bak, which fails. Escaping for the shell without upsetting find also appears non-trivial, due to the multiple levels of escaping (Make, then sh, then sh again, then find) You should instead use -regex: (cd ${WRKSRC}/JDownloader && ${COPYTREE_SHARE} \* \ ${PREFIX}/${PORTNAME}/=A0'! ( -regex .*.exe )' ) Hideous, but it works. (If you're unfamiliar with REs, I might point out that you shouldn't forget the leading dot ;)) Chris