From owner-freebsd-current Thu Apr 25 18:15:12 2002 Delivered-To: freebsd-current@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id 4650837B41C; Thu, 25 Apr 2002 18:15:05 -0700 (PDT) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [172.16.0.12]) by Awfulhak.org (8.12.2/8.12.2) with ESMTP id g3Q1F0sG074640; Fri, 26 Apr 2002 02:15:00 +0100 (BST) (envelope-from brian@freebsd-services.com) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.12.3/8.12.3) with ESMTP id g3Q1CNxH066034; Fri, 26 Apr 2002 02:12:24 +0100 (BST) (envelope-from brian@freebsd-services.com) Message-Id: <200204260112.g3Q1CNxH066034@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Ian Dowse Cc: Harti Brandt , brian@freebsd.org, current@freebsd.org Subject: Re: Revision 1.88 of kern_linker.c breaks module loading for diskless In-Reply-To: Message from Ian Dowse of "Fri, 26 Apr 2002 01:09:16 BST." <200204260109.aa01691@salmon.maths.tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 26 Apr 2002 02:12:23 +0100 From: Brian Somers Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > In message <20020425184846.Q795-100000@beagle.fokus.gmd.de>, Harti Brandt write > s: > >the check for rootdev != NODEV introduced in rev 1.88 breaks loading of > >kernel modules from an NFS mounted root in diskless configurations. > >Dropping in gdb and printing rootdev shows -1 which is, I assume, NODEV. > > Ah, that would explain a problem I saw recently on a netbooted box > where kldload only worked with full module paths. Could `rootvnode' > be checked for NULL instead? Hi, The intent is to discover whether there's a filesystem yet (vn_open() will die horribly otherwise). My use of rootdev is (obviously) flawed. AFAICT, either rootvp or rootvnode should be used, but I can't tell the difference between the two at a glance and am lacking development resources right now (my development box seems to enjoy dropping cores too frequently to build a kernel at the moment). If somebody could test that rootvnode or rootvp are non-NULL after an NFS-mounted root is set up, I'd thankfully approve the quick fix... :*) Cheers. > Ian -- Brian http://www.freebsd-services.com/ Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message