From owner-svn-ports-head@FreeBSD.ORG Sun Nov 30 17:02:02 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4A91A8A8; Sun, 30 Nov 2014 17:02:02 +0000 (UTC) Received: from mailrelay009.isp.belgacom.be (mailrelay009.isp.belgacom.be [195.238.6.176]) by mx1.freebsd.org (Postfix) with ESMTP id 576B596C; Sun, 30 Nov 2014 17:02:00 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AoQGAClMe1RbsIre/2dsb2JhbABbgwZRTQvHAIZOAoEHFwEBAQEBfYQDAQEEOhwjEAsOCgkaCw8qHgYTiEQBCNImAQEBAQEBAQMBAQEBAQEBG5B7B4RIBZVShnSBa5NZgjeBRT4wgkcBAQE Received: from 222.138-176-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.176.138.222]) by relay.skynet.be with ESMTP; 30 Nov 2014 18:00:50 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.9/8.14.9) with ESMTP id sAUH0mMt039499; Sun, 30 Nov 2014 18:00:49 +0100 (CET) (envelope-from tijl@FreeBSD.org) Date: Sun, 30 Nov 2014 18:00:48 +0100 From: Tijl Coosemans To: Alexey Dokuchaev Subject: Re: svn commit: r373636 - in head: . Mk/Uses archivers/gtar audio/clementine-player audio/gbemol audio/gkrellmms2 audio/gkrellmss2 audio/gkrellmvolume2 audio/kstreamripper audio/pavucontrol audio/pms a... Message-ID: <20141130180048.35a04df5@kalimero.tijl.coosemans.org> In-Reply-To: <20141130154810.GA44358@FreeBSD.org> References: <201411291822.sATIMXqv034069@svn.freebsd.org> <20141130154810.GA44358@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Nov 2014 17:02:02 -0000 On Sun, 30 Nov 2014 15:48:10 +0000 Alexey Dokuchaev wrote: > On Sat, Nov 29, 2014 at 06:22:33PM +0000, Tijl Coosemans wrote: >> New Revision: 373636 >> URL: https://svnweb.freebsd.org/changeset/ports/373636 >> QAT: https://qat.redports.org/buildarchive/r373636/ >> >> Log: >> Split devel/gettext in devel/gettext-runtime and devel/gettext-tools. The >> first contains runtime libraries such as libintl and the latter contains >> developer tools such as msgfmt. Ports that use gettext will usually need >> a LIB_DEPENDS on gettext-runtime and a BUILD_DEPENDS on gettext-tools. >> >> USES=gettext-runtime can be used to set a LIB/BUILD/RUN_DEPENDS on >> devel/gettext-runtime and USES=gettext-tools can be used to set a >> BUILD/RUN_DEPENDS on devel/gettext-tools. USES=gettext is now the same >> as "USES=gettext-runtime gettext-tools" meaning a LIB_DEPENDS on >> devel/gettext-runtime and a BUILD_DEPENDS on devel/gettext-tools. > > Wouldn't it be better if instead of two new Uses/gettext-* files, existing > Uses/gettext.mk accepted arguments (like, USES=gettext:build and :run)? > > Similar to what other Uses/* files are already doing. USES=gettext-runtime has three arguments (lib, build and run) and USES=gettext-tools has two (build and run). Combining these in one USES=gettext means you need five arguments: runtime-lib, runtime-build, runtime-run, tools-build and tools-run. The default would be "runtime-lib,tools-build". The two separate USES are easier to implement and easier to understand in my opinion.