From owner-cvs-src@FreeBSD.ORG Thu May 20 13:04:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3699816A4CE; Thu, 20 May 2004 13:04:42 -0700 (PDT) Received: from rwcrmhc13.comcast.net (rwcrmhc13.comcast.net [204.127.198.39]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2372C43D54; Thu, 20 May 2004 13:04:42 -0700 (PDT) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([24.7.73.28]) by comcast.net (rwcrmhc13) with ESMTP id <2004052020044101500qe0cne>; Thu, 20 May 2004 20:04:41 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id NAA74031; Thu, 20 May 2004 13:04:40 -0700 (PDT) Date: Thu, 20 May 2004 13:04:39 -0700 (PDT) From: Julian Elischer To: Thomas Moestl In-Reply-To: <20040520195617.GA2087@timesink.dyndns.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sparc64/sparc64 vm_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 May 2004 20:04:42 -0000 On Thu, 20 May 2004, Thomas Moestl wrote: > On Thu, 2004/05/20 at 11:48:19 -0700, Julian Elischer wrote: > > While you are there, can you rename it to cpu_exit2() > > as it has nothing to do with the scheduler.. > > As I mentioned previously, the connection is that this function must > be called with sched_lock held (and it must be held until the final > cpu_throw() after that). It does tasks that have a connection to > thread switching, so the name is not really inappropriate. > > cpu_exit2 is far less descriptive as a name. but less misleading than cpu_sched_sxit() switching is nothing to do with the scheduler.. If there is a cpu_exit() and a cpu_exit2() than one assumes that there would be a comment at cpu_exit2() explaining why it needs to be separate from cpu_exit(). cpu_sched_exit() just makes someone looking for scheduler components to get a false positive, and waste time staring at it trying to work out what the f*ck it has to do with the scheduler. cpu_exit_schedlocked() or something would be ok (if not to verbose) > > - Thomas > > -- > Thomas Moestl http://www.tu-bs.de/~y0015675/ > http://people.FreeBSD.org/~tmm/ > "I try to make everyone's day a little more surreal." > -- Calvin and Hobbes >