From owner-p4-projects@FreeBSD.ORG  Wed Nov  5 20:53:49 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 9C53B1065678; Wed,  5 Nov 2008 20:53:49 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5F72B1065672
	for <perforce@freebsd.org>; Wed,  5 Nov 2008 20:53:49 +0000 (UTC)
	(envelope-from peter-gmail@wemm.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 4DF328FC17
	for <perforce@freebsd.org>; Wed,  5 Nov 2008 20:53:49 +0000 (UTC)
	(envelope-from peter-gmail@wemm.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id mA5KrnBN010399
	for <perforce@freebsd.org>; Wed, 5 Nov 2008 20:53:49 GMT
	(envelope-from peter-gmail@wemm.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id mA5KrnD5010397
	for perforce@freebsd.org; Wed, 5 Nov 2008 20:53:49 GMT
	(envelope-from peter-gmail@wemm.org)
Date: Wed, 5 Nov 2008 20:53:49 GMT
Message-Id: <200811052053.mA5KrnD5010397@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	peter-gmail@wemm.org using -f
From: Peter Wemm <peter@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 152547 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Nov 2008 20:53:49 -0000

http://perforce.freebsd.org/chv.cgi?CH=152547

Change 152547 by peter@peter_daintree on 2008/11/05 20:53:33

	Tidy up thr_exit wrapper a little.

Affected files ...

.. //depot/projects/valgrind/coregrind/m_syswrap/syswrap-freebsd.c#26 edit

Differences ...

==== //depot/projects/valgrind/coregrind/m_syswrap/syswrap-freebsd.c#26 (text+ko) ====

@@ -168,6 +168,7 @@
          reallocation.  We need to make sure we don't touch the stack
          between marking it Empty and exiting.  Hence the
          assembler. */
+      /* QQQ might have to use thr_exit here */
 #if defined(VGP_x86_freebsd)	/* FreeBSD has args on the stack */
       asm volatile (
          "movl	%1, %0\n"	/* set tst->status = VgTs_Empty */
@@ -1765,13 +1766,15 @@
 {
    ThreadState *tst;
 
+   PRINT( "sys_thr_exit ( %#lx )", ARG1 );
+   PRE_REG_READ1(long, "thr_exit", long *, "status");
+
+   if (ARG1)
+      PRE_MEM_WRITE( "thr_exit(status)", ARG1, sizeof(long) );
    tst = VG_(get_ThreadState)(tid);
    tst->exitreason = VgSrc_ExitThread;
-
+   tst->os_state.exitcode = 0;
    VG_(exit_thread)(tid);
-   PRINT( "sys_thr_exit ( %#lx )", ARG1 );
-   PRE_REG_READ1(long, "thr_exit", long *, "status");
-// PRE_MEM_WRITE( "thr_exit()", ARG1, sizeof(long));
 }
 
 PRE(sys_thr_set_name)