From owner-cvs-ports@FreeBSD.ORG Sun Jul 31 08:50:22 2011 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 857ED106566C; Sun, 31 Jul 2011 08:50:22 +0000 (UTC) (envelope-from support@rtmpd.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 5B6798FC12; Sun, 31 Jul 2011 08:50:21 +0000 (UTC) Received: by fxe4 with SMTP id 4so4972080fxe.13 for ; Sun, 31 Jul 2011 01:50:20 -0700 (PDT) Received: by 10.223.76.17 with SMTP id a17mr4592414fak.32.1312102220193; Sun, 31 Jul 2011 01:50:20 -0700 (PDT) Received: from [10.0.1.2] ([79.115.160.60]) by mx.google.com with ESMTPS id j18sm1324579faa.22.2011.07.31.01.50.19 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 31 Jul 2011 01:50:19 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v1244.3) Content-Type: multipart/signed; boundary="Apple-Mail=_06D3707C-2344-43FD-B072-18B77A77E5C3"; protocol="application/pkcs7-signature"; micalg=sha1 From: C++ RTMP Server Support In-Reply-To: <4E3516C3.9070605@FreeBSD.org> Date: Sun, 31 Jul 2011 11:50:18 +0300 Message-Id: <4CDE28BF-86F8-4454-B49C-675184173549@rtmpd.com> References: <201107301549.p6UFn7rK070976@repoman.freebsd.org> <4E3495B0.3070405@FreeBSD.org> <4E35108D.1040907@FreeBSD.org> <4E3510F7.2000405@FreeBSD.org> <7C192122-697C-49BB-AADB-446C24962000@rtmpd.com> <4E3516C3.9070605@FreeBSD.org> To: Doug Barton X-Mailer: Apple Mail (2.1244.3) X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Jin-Sih Lin , cvs-ports@FreeBSD.org, Li-Wen Hsu , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/crtmpserver Makefile distinfo pkg-plist ports/net/crtmpserver/files crtmpserver.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2011 08:50:22 -0000 --Apple-Mail=_06D3707C-2344-43FD-B072-18B77A77E5C3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=iso-8859-1 Finally, got it :) I'll prepare a patch right now which will include the special $pidfile = variable. Tx for you patience On Jul 31, 2011, at 11:48 AM, Doug Barton wrote: > On 07/31/2011 01:34, C++ RTMP Server Support wrote: >> Oh, I see the difference now. You basically use another construct to >> gather the (default) values. IMHO, my solution is much much clear >> because all variables which are read from rc.conf are in one single >> place and for beginners like me the script is easier to read. >>=20 >> Besides, you remove one variable (crtmpserver_config) and you put >> it's default value inside the required_files variable, but you add >> another one called pidfile. >>=20 >> Again, IMHO, my version is easier to read.=20 >=20 > You still don't understand. >=20 > pidfile=3D is a requirement. As I said in my first message, it's = special > to rc.subr. This needs to be fixed. >=20 > As for how pidfile=3D and required_files=3D are set, that's a style = issue > that I'm less concerned about. What you are saying is that this is > easier to read: >=20 > : ${name_config:=3Dfoo} > : ${name_pidfile:=3Dbar} >=20 > required_files=3D$name_config > pidfile=3D$name_pidfile >=20 > What I'm saying is that doing it that way means that you're working > harder than you have to. The way I had it in the patch means that each > variable only has to be handled once. It may be slightly more = difficult > to read for novices, but it's not _that_ complex; and reduces the > chances that a mistake will be made. However, if you choose not to use > the style that I suggested, I'm not too concerned about that. >=20 > However, the pidfile issue has to be fixed. >=20 >=20 > Doug >=20 > --=20 >=20 > Nothin' ever doesn't change, but nothin' changes much. > -- OK Go >=20 > Breadth of IT experience, and depth of knowledge in the DNS. > Yours for the right price. :) http://SupersetSolutions.com/ >=20 ------ C++ RTMP Server Support Email: support@rtmpd.com Web: http://www.rtmpd.com --Apple-Mail=_06D3707C-2344-43FD-B072-18B77A77E5C3--