From owner-freebsd-gnome@FreeBSD.ORG Fri Feb 25 09:00:57 2005 Return-Path: Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C199016A4CE; Fri, 25 Feb 2005 09:00:57 +0000 (GMT) Received: from 212.106.237.41.adsl.jazztel.es (212.106.236.80.adsl.jazztel.es [212.106.236.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id BDEA843D46; Fri, 25 Feb 2005 09:00:55 +0000 (GMT) (envelope-from josemi@freebsd.jazztel.es) Received: from redesjm.local (orion.redesjm.local [192.168.254.16]) j1P8LK58066354; Fri, 25 Feb 2005 09:21:20 +0100 (CET) (envelope-from josemi@freebsd.jazztel.es) Received: from localhost (localhost [[UNIX: localhost]]) by redesjm.local (8.13.3/8.13.3/Submit) id j1P8MHMV000742; Fri, 25 Feb 2005 09:22:17 +0100 (CET) (envelope-from josemi@freebsd.jazztel.es) X-Authentication-Warning: orion.redesjm.local: freebsd set sender to josemi@freebsd.jazztel.es using -f From: Jose M Rodriguez To: Joe Marcus Clarke Date: Fri, 25 Feb 2005 09:22:16 +0100 User-Agent: KMail/1.7.2 References: <200502250756.j1P7uEn0023933@freefall.freebsd.org> In-Reply-To: <200502250756.j1P7uEn0023933@freefall.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200502250922.17098.josemi@freebsd.jazztel.es> X-AntiVirus: checked by AntiVir Milter (version: 1.1.0-3; AVE: 6.29.0.8; VDF: 6.29.0.100; host: antares.redesjm.local) cc: gnome@freebsd.org Subject: Re: ports/75816: [PATCH] www/firefox: new mozilla.sh and package script X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Feb 2005 09:00:57 -0000 El Viernes, 25 de Febrero de 2005 08:56, Joe Marcus Clarke escribi=F3: > Synopsis: [PATCH] www/firefox: new mozilla.sh and package script > > State-Changed-From-To: open->closed > State-Changed-By: marcus > State-Changed-When: Fri Feb 25 07:52:11 GMT 2005 > State-Changed-Why: > I've committed some of this. What I didn't commit was the PIS work.=20 > While the framework might be there to embed RC scripts into Mozilla > and Firefox, I don't think this is the right place to add sound > server support. I don't want to get bogged down in a lot of local > scripts that make these ports unsupportable, or in violation of our > license agreement with Mozilla. > Please, consider the cleanhome moz_pis for firefox. This makes firefox=20 upgrades don't be hurt by local profile. > As for your pkg-[de]install work, I didn't see a real advantage of > moving some of these things out into scripts. Plus, it looks like > your pkg-deinstall would nuke all of browser_plugins. > Only make this happens from packages, not only from ports. As an=20 example, you get the java plugin working when you install the=20 firefox/mozilla package. I'll investigate the pkg-deinstall. > The rest of patches looked okay, and were merged. In the future, > please do all diffs frome one level above the directory in question.=20 > For example: > > diff -ruN firefox.orig firefox > > This makes patching much easier. Also, please don't submit diffs > against CVS versions. If a new version hasn't been released, either > wait, or submit the diff against the current version in the ports > tree. Thanks. > =2D- josemi > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D75816