From owner-cvs-src@FreeBSD.ORG  Fri Jan 20 05:35:30 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DA57916A41F;
	Fri, 20 Jan 2006 05:35:30 +0000 (GMT)
	(envelope-from csjp@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id ABEFF43D45;
	Fri, 20 Jan 2006 05:35:30 +0000 (GMT)
	(envelope-from csjp@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k0K5ZUJN035010;
	Fri, 20 Jan 2006 05:35:30 GMT
	(envelope-from csjp@repoman.freebsd.org)
Received: (from csjp@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k0K5ZUTe035009;
	Fri, 20 Jan 2006 05:35:30 GMT (envelope-from csjp)
Message-Id: <200601200535.k0K5ZUTe035009@repoman.freebsd.org>
From: "Christian S.J. Peron" <csjp@FreeBSD.org>
Date: Fri, 20 Jan 2006 05:35:28 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/netinet ip_fw2.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jan 2006 05:35:31 -0000

csjp        2006-01-20 05:35:28 UTC

  FreeBSD src repository

  Modified files:
    sys/netinet          ip_fw2.c 
  Log:
  - Change the return type for init_tables from void to int so we can propagate
    errors from rn_inithead back to the ipfw initialization function.
  - Check return value of rn_inithead for failure, if table allocation has
    failed for any reason, free up any tables we have created and return ENOMEM
  - In ipfw_init check the return value of init_tables and free up any mutexes or
    UMA zones which may have been created.
  - Assert that the supplied table is not NULL before attempting to dereference.
  
  This fixes panics which were a result of invalid memory accesses due to failed
  table allocation. This is an issue mainly because the R_Zalloc function is a
  malloc(M_NOWAIT) wrapper, thus making it possible for allocations to fail.
  
  Found by:       Coverity Prevent (tm)
  Coverity ID:    CID79
  MFC after:      1 week
  
  Revision  Changes    Path
  1.123     +25 -10    src/sys/netinet/ip_fw2.c