From owner-freebsd-ports@FreeBSD.ORG Fri Aug 10 19:44:55 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8CF3E106564A; Fri, 10 Aug 2012 19:44:55 +0000 (UTC) (envelope-from kob6558@gmail.com) Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id CDD6A8FC0C; Fri, 10 Aug 2012 19:44:54 +0000 (UTC) Received: by wgbds11 with SMTP id ds11so1603455wgb.31 for ; Fri, 10 Aug 2012 12:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=2G2ot7/p8DyekBwvIAMfsRXWgBawuq5fb5VLO4kBxNo=; b=n+eFMls0TFYKHN+H09RJp/GsmrjAwzlJ4onlEuKPRvOh1jwZRpB3e33RvIXxbCekEy nXd5Qc4mPvrheIfLtHon3sNwyVOCoTMYwsx0J6gqEkrzYXBC3RenSyx7K0NrZouFpU9r SNP7BokSZtJEoT/zm6cwY+eb9iNdewp7ilJgcN4Rn/0F4rn/ciAgM7JN5FP1/Vxs7UYC SaRy3Xfl9G6POueXKBnhLkuNPBt8K9zrlVYBLvh2WETkDc1Uzf3PeO056wxDLziK5i2S Xzs+NOOTreK1uEZHZKPnwrm4cqLT1ebA+cnaG2E1NzuFnA78CUDdaVdKbw9Cxj1F8rC7 YCIQ== MIME-Version: 1.0 Received: by 10.216.181.67 with SMTP id k45mr144130wem.17.1344627890625; Fri, 10 Aug 2012 12:44:50 -0700 (PDT) Received: by 10.223.100.205 with HTTP; Fri, 10 Aug 2012 12:44:50 -0700 (PDT) In-Reply-To: References: <5025228E.5030705@minibofh.org> Date: Fri, 10 Aug 2012 12:44:50 -0700 Message-ID: From: Kevin Oberman To: Chris Rees Content-Type: text/plain; charset=UTF-8 Cc: "b. f." , Jordi Espasa Clofent , tor-dev@torproject.org, freebsd-ports@freebsd.org Subject: Re: tcmalloc in Tor FreeBSD port X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2012 19:44:55 -0000 On Fri, Aug 10, 2012 at 10:34 AM, Chris Rees wrote: > Forwarding to tor-dev mailing list; this is their problem. > > On 10 August 2012 18:15, Kevin Oberman wrote: >> On Fri, Aug 10, 2012 at 8:02 AM, Jordi Espasa Clofent >> wrote: >>> Hi all, >>> >>> Please, read the follow thread in tor-dev to be in the loop: >>> https://lists.torproject.org/pipermail/tor-dev/2012-August/003878.html >>> >>> I tried to contact the mantainer according to Makefile and Freshports, but I >>> didn't receive any answer. So I guess this mail-list is probably the most >>> accurate place to ask. >> >> First, bf is typically pretty active, so he (she?) must be away or you >> would have heard from him (her?) > > He :) > >> Looks like this broke when the port was converted to use OPTIONSNG >> about two months ago. I am not a make wizard or even close to it, but >> the options code is clearly not doing what it's supposed to be doing. >> You can probably roll the Makefile back to r297464, edit the >> DISTVERSION to "DISTVERSION= 0.2.2.37", remove the >> "ftp://ftp.fodt.it/pub/mirror/tor/dist/ \" line, keep the rest of the >> existing port, and build it. >> >> If I get a few minutes, I will see if I can figure out why the options >> are not working after the change to OPTIONSNG. I have a port htat I >> really need to convert to OPTIONSNG, so maybe I'll get that done, too. > > Brendan's code in the port is perfectly fine. > > The configure.in is where the problem lies; > > if test x$tcmalloc = xyes ; then > using_custom_malloc=yes > fi > if test $using_custom_malloc = no ; then > AC_CHECK_FUNCS(mallinfo malloc_good_size malloc_usable_size) > fi > > ^^^ this stanza is included before $tcmalloc is set; examine where it > is set in configure further down; > > # Check whether --with-tcmalloc was given. > if test "${with_tcmalloc+set}" = set; then : > withval=$with_tcmalloc; tcmalloc=yes > else > tcmalloc=no > fi > > Oops! > > The result is that using_custom_malloc will never be set to yes, and > tcmalloc will probably never be used. > > Chris Thanks, Chris. After spending some time staring at the Makefile, it looked like the OPTIONS stuff was all correct and it is pretty trivial, too, so I was getting ready to look at the configure stuff in tor, but you beat me to it. Just saved me at very least several minutes. -- R. Kevin Oberman, Network Engineer E-mail: kob6558@gmail.com