From owner-cvs-all@FreeBSD.ORG Thu Nov 15 19:48:30 2007 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9785E16A418; Thu, 15 Nov 2007 19:48:30 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 65B2613C514; Thu, 15 Nov 2007 19:48:30 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 493B247018; Thu, 15 Nov 2007 14:50:24 -0500 (EST) Date: Thu, 15 Nov 2007 19:48:25 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Julian Elischer In-Reply-To: <473C901F.1080906@elischer.org> Message-ID: <20071115194710.L82897@fledge.watson.org> References: <200711151416.lAFEGKJ6059040@repoman.freebsd.org> <473C865D.8070809@elischer.org> <20071115181401.GA17094@troutmask.apl.washington.edu> <473C901F.1080906@elischer.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, Gleb Smirnoff , src-committers@freebsd.org, cvs-all@freebsd.org, Steve Kargl Subject: Re: cvs commit: src/sys/kern kern_kse.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2007 19:48:30 -0000 On Thu, 15 Nov 2007, Julian Elischer wrote: >>> "no matter how small the change, use diff + patch to move it across." >> >> After applying the patch on your commit machine, is it too difficult to >> actually retest before committing? This would catch the broken commit >> before it becomes a Tinderbox issue. >> >> Seems to be a QA problem on your part. > > yes.. but I can't do a compile from my mac. (my commit machine). The answer > is to be rigorous about how I move the patch from the build machine to the > commit machine. > > This is a temporary situation. new infrastructure will let me commit from my > build machine again. I find having a copy of Parallels (or VMWare) around very useful for precisely this situation -- it means that even when I have only the Mac around I can easily do a local test build. The various VM packages certainly have their limitations, but they're far better than nothing. Robert N M Watson Computer Laboratory University of Cambridge