From owner-svn-src-all@FreeBSD.ORG  Sun Jul 10 08:27:01 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3743F106564A;
	Sun, 10 Jul 2011 08:27:01 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail07.syd.optusnet.com.au (mail07.syd.optusnet.com.au
	[211.29.132.188])
	by mx1.freebsd.org (Postfix) with ESMTP id AB1958FC08;
	Sun, 10 Jul 2011 08:27:00 +0000 (UTC)
Received: from c122-106-165-191.carlnfd1.nsw.optusnet.com.au
	(c122-106-165-191.carlnfd1.nsw.optusnet.com.au [122.106.165.191])
	by mail07.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	p6A8Qv31026742
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sun, 10 Jul 2011 18:26:58 +1000
Date: Sun, 10 Jul 2011 18:26:57 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Kevin Lo <kevlo@FreeBSD.org>
In-Reply-To: <201107100714.p6A7EXHZ034797@svn.freebsd.org>
Message-ID: <20110710181242.K2019@besplex.bde.org>
References: <201107100714.p6A7EXHZ034797@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r223904 - head/lib/libstand
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Jul 2011 08:27:01 -0000

On Sun, 10 Jul 2011, Kevin Lo wrote:

> Log:
>  style(9) cleanup
>
> Modified:
>  head/lib/libstand/zalloc_defs.h
>
> Modified: head/lib/libstand/zalloc_defs.h
> ==============================================================================
> --- head/lib/libstand/zalloc_defs.h	Sun Jul 10 06:57:00 2011	(r223903)
> +++ head/lib/libstand/zalloc_defs.h	Sun Jul 10 07:14:32 2011	(r223904)
> @@ -38,8 +38,8 @@
> #define DMALLOCDEBUG		/* add debugging code to gather stats */
> #define ZALLOCDEBUG
>
> -#include <string.h>
> #include <sys/stdint.h>
> +#include <string.h>
> #include "stand.h"
>
> typedef uintptr_t iaddr_t;	/* unsigned int same size as pointer	*/
>

It still uses a wrong path to stdint.h, sigh.  It needs to be a bit
careful to avoid any libc features, but there are unlikely to be any
in <stdint.h> and in practice there cannot be any since <stdint.h>
is just a like to <sys/stdint.h>.  Similarly for a few other includes,
especially in bzipfs.c.  There's a <sys/errno.h> instead of the standard
and in practice identical <errno.h>, and a <sys/fcntl.h>...  The only
other dubious <sys> includes in libstand are of <sys/dirent.h> and
<sys/unistd.h>.  For these, the standard includes are less obviously
correct since they are intentionally not just symlinks to the <sys>
ones.

It happens that the new order is still correct when there is no bogus
<sys> group of includes.  sys/stdint.h was also unsorted internally
(d was after r but should be before).

Bruce