From owner-cvs-all@FreeBSD.ORG Mon Aug 14 23:40:43 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C650016A4DF; Mon, 14 Aug 2006 23:40:43 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 354F243D45; Mon, 14 Aug 2006 23:40:43 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout1.pacific.net.au (Postfix) with ESMTP id C824E5A7D14; Tue, 15 Aug 2006 09:40:39 +1000 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (8.13.4/8.13.4/Debian-3sarge1) with ESMTP id k7ENebLY002083; Tue, 15 Aug 2006 09:40:38 +1000 Date: Tue, 15 Aug 2006 09:40:36 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Dag-Erling Smorgrav In-Reply-To: <200608141328.k7EDSrRB084019@repoman.freebsd.org> Message-ID: <20060815085001.S32503@delplex.bde.org> References: <200608141328.k7EDSrRB084019@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk kmod.mk src/sys/modules/if_ef Makefile src/sys/modules/if_ppp Makefile src/sys/modules/netgraph/mppc Makefile src/sys/modules/sound/sound Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Aug 2006 23:40:43 -0000 On Mon, 14 Aug 2006, Dag-Erling Smorgrav wrote: > des 2006-08-14 13:28:53 UTC > > FreeBSD src repository > > Modified files: > sys/conf kern.post.mk kmod.mk > sys/modules/if_ef Makefile > sys/modules/if_ppp Makefile > sys/modules/netgraph/mppc Makefile > sys/modules/sound/sound Makefile > Log: > Don't use touch when what is really meant is :> (create an empty file, or > truncate it if it exists) or :>> (ensure the file exists, but don't change > it if it already does) Why not just ">" or ">>"? > Reviewed by: ru > MFC after: 2 weeks > > Revision Changes Path > 1.96 +1 -1 src/sys/conf/kern.post.mk > 1.210 +2 -2 src/sys/conf/kmod.mk > 1.14 +4 -4 src/sys/modules/if_ef/Makefile > 1.36 +3 -3 src/sys/modules/if_ppp/Makefile > 1.14 +1 -1 src/sys/modules/netgraph/mppc/Makefile > 1.19 +1 -1 src/sys/modules/sound/sound/Makefile I use echo -n for one of these. "echo" is less cryptic than ">", and is probably faster since /bin/echo is smaller than /bin/sh and is used enough to keep it cached. In sound/Makefile, the cleanup should be to remove the touching (now emptying) since the touching used to be just worse than the default of emptying and is now just the same as the default (but takes extra code). Emptying instead of touching could in theory handle things changing underneath, but it doesn't actually help for most cases since most cases involve options files and opt_foo.h never (?) has any dependencies, so opt_foo.h only gets touched/created when it doesn't already exist. In sound/Makefile, it made even less difference because it would take ${MACHINE_ARCH} changing underneath to change the correct contents of the options file. Bruce