From owner-cvs-src@FreeBSD.ORG Thu Mar 9 18:43:17 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D46F816A420; Thu, 9 Mar 2006 18:43:17 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5102643D45; Thu, 9 Mar 2006 18:43:17 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost (john@localhost [127.0.0.1]) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k29IhGSi045076; Thu, 9 Mar 2006 13:43:16 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Sam Leffler Date: Thu, 9 Mar 2006 13:38:25 -0500 User-Agent: KMail/1.9.1 References: <200603091711.k29HBI49013996@repoman.freebsd.org> <200603091335.23964.jhb@freebsd.org> In-Reply-To: <200603091335.23964.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200603091338.28350.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1319/Wed Mar 8 20:00:26 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-3.1 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2006 18:43:18 -0000 On Thursday 09 March 2006 13:35, John Baldwin wrote: > On Thursday 09 March 2006 12:11, Sam Leffler wrote: > > sam 2006-03-09 17:11:18 UTC > > > > FreeBSD src repository > > > > Modified files: > > release Makefile > > Log: > > handle KERNELS as before > > > > Submitted by: ru, andrew > > Does this actually work though? I thought if you did > > make KERNELS=FOO release > > That any KERNELS?= or KERNELS+= lines would be ignored and the > value on the command line would take precedence. Alternatively, > if you do 'env KERNELS=foo make release' then KERNELS+= would > work. nm, I see it does work because the += is only really used inside the nested make. Note that in the default case you are going to build the kernels twice though I think. :) Because KERNELS will be set to 'GENERIC SMP' in the outer make (and thus set that way in the 'mk' script) and then the 'make doRELEASE' will add 'GENERIC SMP' to it again. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org