From owner-freebsd-virtualization@FreeBSD.ORG  Mon Jul 22 19:01:34 2013
Return-Path: <owner-freebsd-virtualization@FreeBSD.ORG>
Delivered-To: freebsd-virtualization@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 079FFD0;
 Mon, 22 Jul 2013 19:01:34 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-wg0-x232.google.com (mail-wg0-x232.google.com
 [IPv6:2a00:1450:400c:c00::232])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4660D2EF0;
 Mon, 22 Jul 2013 19:01:33 +0000 (UTC)
Received: by mail-wg0-f50.google.com with SMTP id m15so934755wgh.5
 for <multiple recipients>; Mon, 22 Jul 2013 12:01:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=lW+wnwyCYHpMvmJkx+B1JdzE65vWVla1R7YXs5jGOJs=;
 b=BHquAVDNXDDsAyU0LaBgg8AkA7wD+QoJnQ2ddY7irTxClFZNtOjFFUMxx9BRELu5GV
 Lmbiik3YDdXTiiC1tL82J87Hyq06gbDIk00oeNh9J0vWXjv4q9LWbHTdxYvU4KETmSY3
 c0QzEXEqF/Ra8ltVQR65HTJtPklTDNqJkH6WhUSzdHuUgnBcU796YuA9nSikf+MxBC/N
 GNsFdlU3AH7PqaPxcKskJ4lXcylSA9IVdaIXDxZLwKmImTjOSiz86+abXvoP3bmhVZaS
 BYKnxPaa2N86huRoiaaY8hSdBpvCBZHpodtZGpqgp/rXsnxrYDxyAy3KaufthvgCSVc7
 5eNQ==
MIME-Version: 1.0
X-Received: by 10.180.82.196 with SMTP id k4mr31144532wiy.0.1374519691607;
 Mon, 22 Jul 2013 12:01:31 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.217.94.132 with HTTP; Mon, 22 Jul 2013 12:01:31 -0700 (PDT)
In-Reply-To: <CAG=rPVd3F2sfwizJuEngxexo0Rby2qwzqpAB4_K-fZXXb8-Rmw@mail.gmail.com>
References: <CAG=rPVfxFiOVOeSyDP=wBubNQCHK5dqcgBBaJjeS6XXtSZSZqg@mail.gmail.com>
 <51ED5308.3020008@gmx.com>
 <CAJ-VmomAC573hrQivfT9Gn_tJn5SkMhM_MK8hUCbtr-7D-NGDw@mail.gmail.com>
 <CAG=rPVd3F2sfwizJuEngxexo0Rby2qwzqpAB4_K-fZXXb8-Rmw@mail.gmail.com>
Date: Mon, 22 Jul 2013 12:01:31 -0700
X-Google-Sender-Auth: Z37cUi3HUr_PvFTKaLqL8JHaA-o
Message-ID: <CAJ-Vmo=jDPrJHXRz8xY9aA-soBx54DjvqkpzdSUvr+4hZ9ExkQ@mail.gmail.com>
Subject: Re: VIMAGE + PF crash in mbuf destructor
From: Adrian Chadd <adrian@freebsd.org>
To: Craig Rodrigues <rodrigc@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "freebsd-virtualization@freebsd.org" <freebsd-virtualization@freebsd.org>,
 freebsd-pf@freebsd.org
X-BeenThere: freebsd-virtualization@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Discussion of various virtualization techniques FreeBSD supports."
 <freebsd-virtualization.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-virtualization>, 
 <mailto:freebsd-virtualization-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-virtualization>
List-Post: <mailto:freebsd-virtualization@freebsd.org>
List-Help: <mailto:freebsd-virtualization-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>, 
 <mailto:freebsd-virtualization-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jul 2013 19:01:34 -0000

Well I'm worried about _other_ stuff causing issues here.

So - what's the "right" behaviour? Does vnet/vimage make the
assumption that for all the mbuf processing/free operations, the vnet
tag/state is set?


-adrian

On 22 July 2013 11:59, Craig Rodrigues <rodrigc@freebsd.org> wrote:
> On Mon, Jul 22, 2013 at 10:11 AM, Adrian Chadd <adrian@freebsd.org> wrote:
>>
>>
>> I don't think the default vnet context is the correct behaviour there.
>> We'd need to figure out what the vnet context of the mbuf is and set
>> that.
>>
>
> What do you think about Marko's suggestion to de-virtualize
> V_pf_mtag_z?  What would be the down side of that?
>
> I don't understand enough of the PF code to understand which variables need
> to
> be virtual and which don't.
>
> --
> Craig