From owner-freebsd-current@FreeBSD.ORG  Thu Sep  1 21:31:10 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F3E28106564A
	for <freebsd-current@freebsd.org>; Thu,  1 Sep 2011 21:31:09 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id CBCDA8FC0C
	for <freebsd-current@freebsd.org>; Thu,  1 Sep 2011 21:31:09 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 6A09146B23;
	Thu,  1 Sep 2011 17:31:09 -0400 (EDT)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id F14228A02E;
	Thu,  1 Sep 2011 17:31:08 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Robert Millan <rmh@debian.org>
Date: Thu, 1 Sep 2011 17:28:13 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110617; KDE/4.5.5; amd64; ; )
References: <CAOfDtXPDAyeZX7adW5Hixa2XwyOFgic=FRU6ipUHZcY15JVQaQ@mail.gmail.com>
In-Reply-To: <CAOfDtXPDAyeZX7adW5Hixa2XwyOFgic=FRU6ipUHZcY15JVQaQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201109011728.13979.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6
	(bigwig.baldwin.cx); Thu, 01 Sep 2011 17:31:09 -0400 (EDT)
Cc: freebsd-current@freebsd.org
Subject: Re: [PATCH] Fix NKPT kernel config option
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Sep 2011 21:31:10 -0000

On Thursday, September 01, 2011 3:46:43 pm Robert Millan wrote:
> Hi John,
> 
> Thanks for adding an NKPT kernel config option (r225194), but this
> doesn't seem to work unless opt_pmap.h is included, see attached
> patch.
> 
> Without this include, there's no garantee that the NKPT definition code:
> 
> #ifndef NKPT
> #define NKPT            32
> #endif
> 
> will use the value specified in config.  Or worse, it may even use
> different values for different .c files.
> 
> -- 
> Robert Millan

In general we force the relevant C files to use opt_*.h includes and avoid
nested includes of those in headers.  Do you know of any C files that do
are using NKPT (or values derived from it) without including opt_pmap.h?  I 
thought they were all covered in the commit.

-- 
John Baldwin