From owner-cvs-ports@FreeBSD.ORG  Thu Dec  1 11:48:22 2011
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 4A4E51065672; Thu,  1 Dec 2011 11:48:22 +0000 (UTC)
Date: Thu, 1 Dec 2011 11:48:22 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: "Sergey A. Osokin" <osa@FreeBSD.org>
Message-ID: <20111201114822.GA63988@FreeBSD.org>
References: <201112011044.pB1Aiql7047544@repoman.freebsd.org>
	<20111201104500.30DC91065789@hub.freebsd.org>
	<20111201110523.GA17923@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20111201110523.GA17923@FreeBSD.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	Pietro Cerutti <gahr@FreeBSD.org>
Subject: Re: [ports] cvs commit: ports/devel/glui Makefile
	ports/devel/glui/files patch-makefile
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Dec 2011 11:48:22 -0000

On Thu, Dec 01, 2011 at 11:05:23AM +0000, Sergey A. Osokin wrote:
> On Thu, Dec 01, 2011 at 10:45:00AM +0000, Pietro Cerutti wrote:
> > gahr        2011-12-01 10:44:52 UTC
> > 
> >   Modified files:
> >     devel/glui           Makefile 
> >     devel/glui/files     patch-makefile 
> >   Log:
> >   - Build and install shared library as well
> >   
> >   Feature safe:   yes
> > 
> > Index: ports/devel/glui/Makefile
> > diff -u ports/devel/glui/Makefile:1.13 ports/devel/glui/Makefile:1.14
> > --- ports/devel/glui/Makefile:1.13	Tue Feb  9 19:39:53 2010
> > +++ ports/devel/glui/Makefile	Thu Dec  1 10:44:52 2011
> > @@ -21,12 +21,13 @@
> >  
> >  WRKSRC=		${WRKDIR}/${DISTNAME}/src
> >  
> > -PLIST_FILES=	include/glui.h lib/libglui.a
> > +PLIST_FILES=	include/glui.h lib/libglui.a lib/libglui.so
> >  PORTDOCS=	*
> >  
> >  do-install:
> >  	${INSTALL_DATA} ${WRKSRC}/include/GL/glui.h ${PREFIX}/include/
> >  	${INSTALL_DATA} ${WRKSRC}/lib/libglui.a ${PREFIX}/lib/
> > +	${INSTALL_DATA} ${WRKSRC}/lib/libglui.so ${PREFIX}/lib/
> >  .if !defined(NOPORTDOCS)
> >  	${MKDIR} ${DOCSDIR}
> >  	${INSTALL_DATA} ${WRKSRC}/doc/glui_manual.pdf ${DOCSDIR}/
> 
> Could you please bump PORTREVISION due to package and pkg-list changes?

While normally, since both old and new packages have correct pkg-list,
bumping PORTREVISION is not necessary, in this case it might be required if
this is dependent port, and consumers might want to link to newly installed
shared library (that is, if previously installed version would not work).

Maintainers of affected ports should take a closer look into this.

./danfe