From owner-svn-src-all@FreeBSD.ORG  Fri Mar 14 15:22:13 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C1821E80;
 Fri, 14 Mar 2014 15:22:13 +0000 (UTC)
Received: from felyko.com (felyko.com [174.136.100.2])
 by mx1.freebsd.org (Postfix) with ESMTP id AA6078D7;
 Fri, 14 Mar 2014 15:22:13 +0000 (UTC)
Received: from [10.0.1.3] (c-24-6-115-18.hsd1.ca.comcast.net [24.6.115.18])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by felyko.com (Postfix) with ESMTPSA id C8E5B39841;
 Fri, 14 Mar 2014 08:22:05 -0700 (PDT)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\))
Subject: Re: svn commit: r262972 - head/sys/dev/usb/input
From: Rui Paulo <rpaulo@FreeBSD.org>
In-Reply-To: <5322CCC5.7020608@bitfrost.no>
Date: Fri, 14 Mar 2014 08:22:16 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <C486FB67-41F4-4E13-8B91-A3AD1203F139@FreeBSD.org>
References: <201403100852.s2A8qUdC045704@svn.freebsd.org>
 <D62898EB-F179-416B-A481-68604873477C@FreeBSD.org>
 <5322CCC5.7020608@bitfrost.no>
To: Hans Petter Selasky <hps@bitfrost.no>
X-Mailer: Apple Mail (2.1874)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Mar 2014 15:22:13 -0000

On 14 Mar 2014, at 02:32, Hans Petter Selasky <hps@bitfrost.no> wrote:

> On 03/14/14 03:15, Rui Paulo wrote:
>> On 10 Mar 2014, at 01:52, Hans Petter Selasky <hselasky@freebsd.org> =
wrote:
>>=20
>>> Author: hselasky
>>> Date: Mon Mar 10 08:52:30 2014
>>> New Revision: 262972
>>> URL: http://svnweb.freebsd.org/changeset/base/262972
>>>=20
>>> Log:
>>>  Ignore USB keyboard driver calls from critical sections.
>>>=20
>>>  Reported by:	Oliver Pinter <oliver.pntr@gmail.com>
>>>  MFC after:	1 week
>>>=20
>>> Modified:
>>>  head/sys/dev/usb/input/ukbd.c
>>>=20
>>> Modified: head/sys/dev/usb/input/ukbd.c
>>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>>> --- head/sys/dev/usb/input/ukbd.c	Mon Mar 10 06:41:48 2014	=
(r262971)
>>> +++ head/sys/dev/usb/input/ukbd.c	Mon Mar 10 08:52:30 2014	=
(r262972)
>>> @@ -1909,6 +1909,12 @@ ukbd_ioctl(keyboard_t *kbd, u_long cmd,
>>> 	int result;
>>>=20
>>> 	/*
>>> +	 * XXX Check of someone is calling us from a critical section:
>>> +	 */
>>> +	if (curthread->td_critnest !=3D 0)
>>> +		return (EDEADLK);
>>=20
>> Shouldn't this panic?
>>=20
>> --
>> Rui Paulo
>>=20
>=20
> Hi,
>=20
> This happens on shutdown, in some special case. Not sure if panic at =
shutdown is appropriate?

I thought this was a programming error.  Do we know the special cases =
and why it happens?

--
Rui Paulo