From owner-freebsd-hackers@FreeBSD.ORG Mon Jun 3 23:41:11 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 50691B40 for ; Mon, 3 Jun 2013 23:41:11 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from tx2outboundpool.messaging.microsoft.com (tx2ehsobe001.messaging.microsoft.com [65.55.88.11]) by mx1.freebsd.org (Postfix) with ESMTP id 1485E1EA7 for ; Mon, 3 Jun 2013 23:41:10 +0000 (UTC) Received: from mail66-tx2-R.bigfish.com (10.9.14.253) by TX2EHSOBE006.bigfish.com (10.9.40.26) with Microsoft SMTP Server id 14.1.225.23; Mon, 3 Jun 2013 23:26:02 +0000 Received: from mail66-tx2 (localhost [127.0.0.1]) by mail66-tx2-R.bigfish.com (Postfix) with ESMTP id 46326340168; Mon, 3 Jun 2013 23:26:02 +0000 (UTC) X-Forefront-Antispam-Report: CIP:66.129.224.52; KIP:(null); UIP:(null); IPV:NLI; H:P-EMHUB02-HQ.jnpr.net; RD:none; EFVD:NLI X-SpamScore: 0 X-BigFish: PS0(zzbb2dI98dI1432Izz1f42h1ee6h1de0h1fdah1202h1e76h1d1ah1d2ah1fc6h1082kz8dhzz31h2a8h668h839hd25hf0ah1288h12a5h12a9h12bdh12e5h137ah139eh13b6h1441h14ddh1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b88h1d0ch1d2eh1d3fh1dfeh1dffh1155h) Received-SPF: softfail (mail66-tx2: transitioning domain of juniper.net does not designate 66.129.224.52 as permitted sender) client-ip=66.129.224.52; envelope-from=sjg@juniper.net; helo=P-EMHUB02-HQ.jnpr.net ; -HQ.jnpr.net ; Received: from mail66-tx2 (localhost.localdomain [127.0.0.1]) by mail66-tx2 (MessageSwitch) id 1370301958877920_27901; Mon, 3 Jun 2013 23:25:58 +0000 (UTC) Received: from TX2EHSMHS039.bigfish.com (unknown [10.9.14.244]) by mail66-tx2.bigfish.com (Postfix) with ESMTP id C8BC04A0055; Mon, 3 Jun 2013 23:25:58 +0000 (UTC) Received: from P-EMHUB02-HQ.jnpr.net (66.129.224.52) by TX2EHSMHS039.bigfish.com (10.9.99.139) with Microsoft SMTP Server (TLS) id 14.1.225.23; Mon, 3 Jun 2013 23:25:58 +0000 Received: from magenta.juniper.net (172.17.27.123) by P-EMHUB02-HQ.jnpr.net (172.24.192.33) with Microsoft SMTP Server (TLS) id 8.3.213.0; Mon, 3 Jun 2013 16:25:57 -0700 Received: from chaos.jnpr.net (chaos.jnpr.net [172.24.29.229]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id r53NPuL13241; Mon, 3 Jun 2013 16:25:57 -0700 (PDT) (envelope-from sjg@juniper.net) Received: from chaos.jnpr.net (localhost [127.0.0.1]) by chaos.jnpr.net (Postfix) with ESMTP id B196958097; Mon, 3 Jun 2013 16:25:56 -0700 (PDT) To: Navdeep Parhar Subject: Re: UNIVERSE_TARGET doesn't seem to work In-Reply-To: <51AD0702.2060802@gmail.com> References: <20130531014320.GA22257@itx> <51AD0702.2060802@gmail.com> Comments: In-reply-to: Navdeep Parhar message dated "Mon, 03 Jun 2013 14:13:38 -0700." From: "Simon J. Gerraty" X-Mailer: MH-E 7.82+cvs; nmh 1.3; GNU Emacs 22.3.1 Date: Mon, 3 Jun 2013 16:25:56 -0700 Message-ID: <20130603232556.B196958097@chaos.jnpr.net> MIME-Version: 1.0 Content-Type: text/plain X-OriginatorOrg: juniper.net X-Mailman-Approved-At: Tue, 04 Jun 2013 01:25:23 +0000 Cc: freebsd-hackers@freebsd.org, sjg@juniper.net X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2013 23:41:11 -0000 On Mon, 3 Jun 2013 14:13:38 -0700, Navdeep Parhar writes: >On 05/30/13 18:43, Navdeep Parhar wrote: >> I build kernel-toolchain and MAKE_JUST_KERNELS (often with NO_CLEAN, but >> not this time) as part of my pre-commit checklist. It doesn't seem to >> work after the switch to bmake. What am I missing? This on a system >> at r251171 with nothing in make.conf or src.conf: >> >> # make -j12 universe UNIVERSE_TARGET=kernel-toolchain >> --- universe_prologue --- So not so much conflicting dependencies, but bmake seems to not like .ORDER and explicit dependencies that effectively say the same thing. That is since there is an explicit dependency: universe_${target}: universe_${target}_prologue it shouldn't be necessary to also express that in the .ORDER This is probably a bug, but identifying exactly where and a fix could take a while. Moving the .ORDER out of the loop like: @@ -373,9 +373,10 @@ .if defined(DOING_TINDERBOX) @rm -f ${FAILFILE} .endif +.ORDER: universe_prologue upgrade_checks universe_targets universe_epilogue .for target in ${TARGETS} universe: universe_${target} -.ORDER: universe_prologue upgrade_checks universe_${target}_prologue universe_${target} universe_epilogue +universe_targets: universe_${target} universe_${target}: universe_${target}_prologue universe_${target}_prologue: @echo ">> ${target} started on `LC_ALL=C date`" would seem to make sense, but fmake runs universe_epilogue too early (which is also a bug). Thus the simplest patch which avoids an error and works for both bmake and fmake is: Index: Makefile =================================================================== --- Makefile (revision 250971) +++ Makefile (working copy) @@ -375,7 +375,7 @@ .endif .for target in ${TARGETS} universe: universe_${target} -.ORDER: universe_prologue upgrade_checks universe_${target}_prologue universe_${target} universe_epilogue +.ORDER: universe_prologue upgrade_checks universe_${target} universe_epilogue universe_${target}: universe_${target}_prologue universe_${target}_prologue: @echo ">> ${target} started on `LC_ALL=C date`"