From owner-svn-src-all@FreeBSD.ORG  Mon Apr  9 23:09:57 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F11481065670;
	Mon,  9 Apr 2012 23:09:57 +0000 (UTC)
	(envelope-from marius@alchemy.franken.de)
Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214])
	by mx1.freebsd.org (Postfix) with ESMTP id 866BB8FC17;
	Mon,  9 Apr 2012 23:09:57 +0000 (UTC)
Received: from alchemy.franken.de (localhost [127.0.0.1])
	by alchemy.franken.de (8.14.4/8.14.4/ALCHEMY.FRANKEN.DE) with ESMTP id
	q39N9oVT029068; Tue, 10 Apr 2012 01:09:50 +0200 (CEST)
	(envelope-from marius@alchemy.franken.de)
Received: (from marius@localhost)
	by alchemy.franken.de (8.14.4/8.14.4/Submit) id q39N9odk029067;
	Tue, 10 Apr 2012 01:09:50 +0200 (CEST) (envelope-from marius)
Date: Tue, 10 Apr 2012 01:09:49 +0200
From: Marius Strobl <marius@alchemy.franken.de>
To: Attilio Rao <attilio@freebsd.org>
Message-ID: <20120409230949.GB68111@alchemy.franken.de>
References: <201204092241.q39MfJZn081610@svn.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201204092241.q39MfJZn081610@svn.freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r234074 - in head/sys: amd64/amd64 i386/i386
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Apr 2012 23:09:58 -0000

On Mon, Apr 09, 2012 at 10:41:19PM +0000, Attilio Rao wrote:
> Author: attilio
> Date: Mon Apr  9 22:41:19 2012
> New Revision: 234074
> URL: http://svn.freebsd.org/changeset/base/234074
> 
> Log:
>   BSP is not added to the mask of valid target CPUs for interrupts
>   in set_apic_interrupt_ids(). Besides, set_apic_interrupts_ids() is not
>   called in the !SMP case too.
>   Fix this by:
>   - Adding the BSP as an interrupt target directly in cpu_startup().
>   - Remove an obsolete optimization where the BSP are skipped in
>     set_apic_interrupt_ids().
>   
>   Reported by:	jh
>   Reviewed by:	jhb
>   MFC after:	3 days
>   X-MFC:		r233961
>   Pointy hat to:	me
> 
> Modified:
>   head/sys/amd64/amd64/machdep.c
>   head/sys/amd64/amd64/mp_machdep.c
>   head/sys/i386/i386/machdep.c
>   head/sys/i386/i386/mp_machdep.c
> 
> Modified: head/sys/amd64/amd64/machdep.c
> ==============================================================================
> --- head/sys/amd64/amd64/machdep.c	Mon Apr  9 22:01:43 2012	(r234073)
> +++ head/sys/amd64/amd64/machdep.c	Mon Apr  9 22:41:19 2012	(r234074)
> @@ -295,6 +295,11 @@ cpu_startup(dummy)
>  	vm_pager_bufferinit();
>  
>  	cpu_setregs();
> +
> +	/*
> +	 * Add BSP as an interrupt target.
> +	 */
> +	intr_add_cpu(0);
>  }

If I'm not mistaken, intr_add_cpu() is under #ifdef SMP, so it should be
here as well.

Marius