From owner-p4-projects  Thu Mar 21  5:25:30 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 06A3C37B417; Thu, 21 Mar 2002 05:25:24 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from rover.village.org (rover.bsdimp.com [204.144.255.66])
	by hub.freebsd.org (Postfix) with ESMTP
	id 31F1837B419; Thu, 21 Mar 2002 05:25:21 -0800 (PST)
Received: from harmony.village.org (harmony.village.org [10.0.0.6])
	by rover.village.org (8.11.3/8.11.3) with ESMTP id g2LDPJi81369;
	Thu, 21 Mar 2002 06:25:20 -0700 (MST)
	(envelope-from imp@village.org)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.11.6/8.11.6) with ESMTP id g2LDPJL16998;
	Thu, 21 Mar 2002 06:25:19 -0700 (MST)
	(envelope-from imp@village.org)
Date: Thu, 21 Mar 2002 06:25:04 -0700 (MST)
Message-Id: <20020321.062504.18991423.imp@village.org>
To: jhb@freebsd.org
Cc: peter@freebsd.org, perforce@freebsd.org
Subject: Re: PERFORCE change 7933 for review
From: "M. Warner Losh" <imp@village.org>
In-Reply-To: <XFMail.20020319131141.jhb@FreeBSD.org>
References: <200203190929.g2J9TnB80357@freefall.freebsd.org>
	<XFMail.20020319131141.jhb@FreeBSD.org>
X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

In message: <XFMail.20020319131141.jhb@FreeBSD.org>
            John Baldwin <jhb@freebsd.org> writes:
: 
: On 19-Mar-2002 Peter Wemm wrote:
: > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=7933
: > 
: > Change 7933 by peter@peter_overcee on 2002/03/19 01:29:12
: > 
: >       add the ia64 IO tag, and add a #error to catch this in future.
: > 
: > Affected files ...
: > 
: > ... //depot/projects/ia64/sys/dev/kbd/atkbdc.c#2 edit
: > 
: > Differences ...
: > 
: > ==== //depot/projects/ia64/sys/dev/kbd/atkbdc.c#2 (text+ko) ====
: > 
: > @@ -159,6 +159,10 @@
: >       tag = I386_BUS_SPACE_IO;
: >  #elif defined(__alpha__)
: >       tag = busspace_isa_io;
: > +#elif defined(__ia64__)
: > +     tag = IA64_BUS_SPACE_IO;
: > +#else
: > +#error "define tag!"
: >  #endif
: >  
: >  #if notyet
: 
: Maybe there should be a MD macro to define what the appropriate bus tag is?

No.  atkbdc should be fixed to properly use the bus tag that the
kernel gives it rather than guessing.  It needs to do this anyway if
we are ever to support some some PC Cards that have keyboard/mouse
ports on them.

Warner

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message