From owner-svn-src-head@FreeBSD.ORG  Tue Jul 30 18:50:37 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id B06BFDEC;
 Tue, 30 Jul 2013 18:50:37 +0000 (UTC)
 (envelope-from obrien@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 98B2624CE;
 Tue, 30 Jul 2013 18:50:37 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r6UIobGO055073;
 Tue, 30 Jul 2013 18:50:37 GMT
 (envelope-from obrien@freefall.freebsd.org)
Received: (from obrien@localhost)
 by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r6UIoaRc055069;
 Tue, 30 Jul 2013 18:50:36 GMT (envelope-from obrien)
Date: Tue, 30 Jul 2013 11:50:34 -0700
From: "David O'Brien" <obrien@FreeBSD.org>
To: Dag-Erling =?unknown-8bit?B?U23DuHJncmF2?= <des@des.no>
Subject: Re: svn commit: r253786 - in head/sys: dev/random
 modules/padlock_rng modules/rdrand_rng modules/yarrow_rng
Message-ID: <20130730185034.GA63635@dragon.NUXI.org>
References: <201307292058.r6TKwA56031193@svn.freebsd.org>
 <86fvuwgrs6.fsf@nine.des.no>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <86fvuwgrs6.fsf@nine.des.no>
X-Operating-System: FreeBSD 10.0-CURRENT
X-MUA-Host: dragon.NUXI.org
X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger?
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: obrien@freebsd.org
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Jul 2013 18:50:37 -0000

On Tue, Jul 30, 2013 at 02:23:53PM +0200, Dag-Erling Smrgrav wrote:
> "David E. O'Brien" <obrien@FreeBSD.org> writes:
> > Log:
> >   Decouple yarrow from random(4) device.
> 
> We've had a policy for several years now that all changes to the PRNG
> code in the kernel and libc must be reviewed by so@.

Hi DES,
Where was this policy published or communicated?
There is no MAINTAINER line in sys/dev/random/, nor an entry in
/usr/src/MAINTAINERS.  It is hard to follow some policy that cannot
be found.

> Please revert
> this commit and submit your patch to secteam@freebsd.org for review.

There was a lot of work put into this patch. 'make tenderbox',
and much boot testing of various kernel configs on both i386,
amd64, both IvyBridge and non-IvyBridge systems, ARM (Beaglebone)
with both statically compiled in random(4) and loaded via modules.

This change does not change any of the PRNG algorithms.

Please see if you cannot review the code within the tree with doing
a whiplash backout-recommit.

Do you have any specific concerns?

-- 
-- David  (obrien@FreeBSD.org)