From owner-cvs-all@FreeBSD.ORG Thu Jan 4 12:45:01 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1E9A016A403; Thu, 4 Jan 2007 12:45:01 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 0741113C44B; Thu, 4 Jan 2007 12:45:01 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l04Cj0F5068333; Thu, 4 Jan 2007 12:45:00 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l04Cj0ZX068332; Thu, 4 Jan 2007 12:45:00 GMT (envelope-from cperciva) Message-Id: <200701041245.l04Cj0ZX068332@repoman.freebsd.org> From: Colin Percival Date: Thu, 4 Jan 2007 12:45:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libarchive archive_private.h archive_read_support_compression_none.c archive_read_support_format_iso9660.c archive_read_support_format_tar.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jan 2007 12:45:01 -0000 cperciva 2007-01-04 12:45:00 UTC FreeBSD src repository Modified files: lib/libarchive archive_private.h archive_read_support_compression_none.c archive_read_support_format_iso9660.c archive_read_support_format_tar.c Log: Convert compression_skip from taking a size_t skip length request and returning the length skipped in a ssize_t to using off_t for both. This does not break any A[BP]Is, since compression_skip is entirely internal to libarchive. If a skip request is > SSIZE_MAX, don't pass it down to the client layer skip function, since those still uses size_t / ssize_t. Instead, just read the data and throw it away. With this commit, libarchive/bsdtar should now successfully skip archive entries of >2GB on 32-bit systems, but does so slower than necessary. The performance will improve with a future A[BP]I breaking commit which makes client layer skip functions use off_t. Discussed with: kientzle MFC after: 1 week Revision Changes Path 1.26 +1 -1 src/lib/libarchive/archive_private.h 1.12 +11 -8 src/lib/libarchive/archive_read_support_compression_none.c 1.17 +2 -2 src/lib/libarchive/archive_read_support_format_iso9660.c 1.47 +1 -1 src/lib/libarchive/archive_read_support_format_tar.c