From owner-cvs-all@FreeBSD.ORG  Thu Jun 30 03:20:08 2011
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 87BBE1065672;
	Thu, 30 Jun 2011 03:20:08 +0000 (UTC)
	(envelope-from sahil@tandon.net)
Received: from spartan.hamla.org (spartan.hamla.org [206.251.255.30])
	by mx1.freebsd.org (Postfix) with ESMTP id 3486B8FC1F;
	Thu, 30 Jun 2011 03:20:07 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by spartan.hamla.org (Postfix) with ESMTP id E2C9A170E5;
	Wed, 29 Jun 2011 23:20:35 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tandon.net; h=
	user-agent:in-reply-to:content-disposition:content-type
	:content-type:mime-version:references:reply-to:message-id
	:subject:subject:from:from:date:date:received; s=aegis; t=
	1309404035; bh=KAHjKsQ7ehLh+tQGjKAOyIEqr9HTwE9cGkpUXB3I7w4=; b=G
	RXT/RJIcBnzI/feL1kLBCwVMuOtXEyWJ5oZFtBTAD4kw6f6OjDYNMrev4dWuLxNi
	FwEU1EJ+0fNuozt4xut0InzUa5xBrlmd3+Ls8WlaY0YGqceUzy8YtWl5c+0ecn7O
	TczbzACQIIintlQthzsZDUbAcBPhJ34MjnVU3yZkgo=
X-Virus-Scanned: by ClamAV at spartan.hamla.org
Received: from spartan.hamla.org ([127.0.0.1])
	by localhost (spartan.hamla.org [127.0.0.1]) (amavisd-new, port 10027)
	with LMTP id Qg+lhpurBONh; Wed, 29 Jun 2011 23:20:35 -0400 (EDT)
Date: Wed, 29 Jun 2011 23:20:04 -0400
From: Sahil Tandon <sahil@FreeBSD.org>
To: Julien Laffaye <jlaffaye@FreeBSD.org>
Message-ID: <20110630032003.GA670@magic.hamla.org>
References: <201106291951.p5TJpHh7000414@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201106291951.p5TJpHh7000414@repoman.freebsd.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/lang/php52 Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Sahil Tandon <sahil@FreeBSD.org>
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jun 2011 03:20:08 -0000

On Wed, 2011-06-29 at 19:51:17 +0000, Julien Laffaye wrote:

>   Modified files:
>     lang/php52           Makefile 
>   Log:
>   Add an option to link against libthr
>   
>   PR:             ports/158423
>   Submitted by:   Frank Wall <fw@moov.de>
>   Approved by:    Alex Keda <admin@lissyara.su> (maintainer), bapt (mentor, implicit)
>   
>   Revision  Changes    Path
>   1.18      +7 -1      ports/lang/php52/Makefile

Why bump PORTREVISION if the new option is off by default and does not
affect the default package?  This is sometimes a grey area, so please do
not misconstrue my question for hostility; I just want to understand
your rationale.  For context, ale@ added the LINKTHR option to lang/php5
last year without a bump:

http://www.freebsd.org/cgi/cvsweb.cgi/ports/lang/php5/Makefile.diff?r1=1.147;r2=1.148

-- 
Sahil Tandon <sahil@FreeBSD.org>