From owner-freebsd-testing@FreeBSD.ORG  Thu May 28 16:49:45 2015
Return-Path: <owner-freebsd-testing@FreeBSD.ORG>
Delivered-To: freebsd-testing@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id AD8EE37C;
 Thu, 28 May 2015 16:49:45 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3D458B99;
 Thu, 28 May 2015 16:49:45 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kostik@localhost [127.0.0.1])
 by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t4SGneG4090603
 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Thu, 28 May 2015 19:49:40 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t4SGneG4090603
Received: (from kostik@localhost)
 by tom.home (8.14.9/8.14.9/Submit) id t4SGneH4090602;
 Thu, 28 May 2015 19:49:40 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Thu, 28 May 2015 19:49:40 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: freebsd-current Current <freebsd-current@freebsd.org>,
 "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>
Subject: Re: Need help reducing compilation warnings in CURRENT
Message-ID: <20150528164940.GC2499@kib.kiev.ua>
References: <CAG=rPVdLjmj8oOeqQQOLr6ShvU=2H3y0j5hg4q8UrB70rj3Xpg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAG=rPVdLjmj8oOeqQQOLr6ShvU=2H3y0j5hg4q8UrB70rj3Xpg@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: freebsd-testing@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Testing on FreeBSD <freebsd-testing.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-testing>, 
 <mailto:freebsd-testing-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-testing/>
List-Post: <mailto:freebsd-testing@freebsd.org>
List-Help: <mailto:freebsd-testing-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-testing>, 
 <mailto:freebsd-testing-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 28 May 2015 16:49:45 -0000

On Wed, May 27, 2015 at 11:30:45PM -0700, Craig Rodrigues wrote:
> Hi,
> 
> I've configured Jenkins to highlight compiler warnings and
> generate a table.  Jenkins also keeps track of new compiler warnings
> over time.  See:
> 
> https://jenkins.freebsd.org/job/FreeBSD_HEAD/warnings7
> 
> Can anyone help improve the code by periodically looking
> at this table and submitting patches to clean up the code?
> 
> Cleaning up compiler warnings is always boring work,
> but it is good to clean up the code over time.

I take some time to do a pass over mine code or code I am somewhat
knowledgable, to correct some 'assigned but not used variable' warnings.
There might be even one real bug in SU code uncovered, but I am not
sure yet.

Please review at https://reviews.freebsd.org/D2665 .
I do not have an intention of splitting this into individual changes.