From owner-freebsd-hackers Fri Sep 7 17:14:47 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from elvis.mu.org (elvis.mu.org [216.33.66.196]) by hub.freebsd.org (Postfix) with ESMTP id 2DACA37B407; Fri, 7 Sep 2001 17:14:43 -0700 (PDT) Received: by elvis.mu.org (Postfix, from userid 1098) id D8CE081D05; Fri, 7 Sep 2001 19:14:37 -0500 (CDT) Date: Fri, 7 Sep 2001 19:14:37 -0500 From: Bill Fumerola To: David O'Brien Cc: Bill Swingle , FreeBSD Hackers Subject: Re: tiny patch to pkg_add Message-ID: <20010907191437.A5216@elvis.mu.org> References: <20010907150416.A38565@dub.net> <20010907162242.A16949@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010907162242.A16949@dragon.nuxi.com>; from obrien@freebsd.org on Fri, Sep 07, 2001 at 04:22:43PM -0700 X-Operating-System: FreeBSD 4.3-FEARSOME-20010712 i386 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Sep 07, 2001 at 04:22:43PM -0700, David O'Brien wrote: > This was introduced in rev 1.38: > > and replace a big if..then..else construct > to determine the package download directory with a lookup table. > > I am very tempted to back this part out. This "better implimentation" > has now had two logic bugs. I wrote that "big if..then..else contstruct" > so that the code would be *so* simple my simple my 1st quarter freshman > students (back when I TA'ed) could understand it. I did it that way > because I got tired of committers constantly breaking -r. the funniest thing about this is that multiple packages in -r was already fixed once by chris piazza in rev 1.29 (almost 2 years ago). -- - bill fumerola / fumerola@yahoo-inc.com / billf@FreeBSD.org / billf@mu.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message