From owner-freebsd-bugs@FreeBSD.ORG  Sun May  4 08:20:12 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C6A6437B401
	for <freebsd-bugs@hub.freebsd.org>;
	Sun,  4 May 2003 08:20:12 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DBFB643F3F
	for <freebsd-bugs@hub.freebsd.org>;
	Sun,  4 May 2003 08:20:11 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h44FKBUp068650
	for <freebsd-bugs@freefall.freebsd.org>;
	Sun, 4 May 2003 08:20:11 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h44FKBFs068649;
	Sun, 4 May 2003 08:20:11 -0700 (PDT)
Resent-Date: Sun, 4 May 2003 08:20:11 -0700 (PDT)
Resent-Message-Id: <200305041520.h44FKBFs068649@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, vd@datamax.bg
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9B94537B401
	for <FreeBSD-gnats-submit@freebsd.org>;
	Sun,  4 May 2003 08:17:12 -0700 (PDT)
Received: from gw-bj2.datamax.bg (datamax.wl.bitex.com [195.34.115.67])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B493443FBD
	for <FreeBSD-gnats-submit@freebsd.org>;
	Sun,  4 May 2003 08:17:11 -0700 (PDT)	(envelope-from vd@datamax.bg)
Received: from sinanica.lg2a.datamax (sinanica.lg2a.datamax [192.168.10.1])
	by gw-bj2.datamax.bg (Postfix) with QMQP id B1E0387C7
	for <FreeBSD-gnats-submit@freebsd.org>;
	Sun,  4 May 2003 18:17:09 +0300 (EEST)
Received: (nullmailer pid 40908 invoked by uid 1001);
	Sun, 04 May 2003 15:17:22 -0000
Message-Id: <1052061442.037828.40907.nullmailer@sinanica.lg2a.datamax>
Date: Sun, 04 May 2003 18:17:22 +0300
From: Vasil@sinanica.lg2a.datamax, Dimov@sinanica.lg2a.datamax
To: FreeBSD-gnats-submit@FreeBSD.org
X-Send-Pr-Version: 3.113
Subject: bin/51750: ipfw2.c typos
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: vd@datamax.bg
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 May 2003 15:20:13 -0000


>Number:         51750
>Category:       bin
>Synopsis:       ipfw2.c typos
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 04 08:20:11 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Vasil Dimov
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
DataMax
>Environment:
System: FreeBSD sinanica.lg2a.datamax 5.0-CURRENT FreeBSD 5.0-CURRENT #1: Wed Apr 30 17:25:36 EEST 2003 root@sinanica.lg2a.datamax:/usr/src/sys/i386/compile/SINANICA i386

>Description:
When outputting errors, in some cases ipfw tries to print av instead of *av, which causes 4 (sizeof(char *)) "random" bytes to be printed. Does not crash, because av ends with '\0'.

After this fix, "WARNS?=0" in the Makefile is no longer needed.

>How-To-Repeat:
ipfw add 100 allow ip from any to any proto foo
ipfw add allow proto boo

>Fix:
cd /usr/src/sbin/ipfw
cat /tmp/ipfw2.c.patch |patch
make && make install
>Release-Note:
>Audit-Trail:
>Unformatted: