From owner-freebsd-hackers  Fri Sep  7 23:36:26 2001
Delivered-To: freebsd-hackers@freebsd.org
Received: from maxim.gbch.net (gw.gbch.net [203.24.22.66])
	by hub.freebsd.org (Postfix) with SMTP id 1280C37B405
	for <hackers@freebsd.org>; Fri,  7 Sep 2001 23:36:21 -0700 (PDT)
Received: (qmail 92646 invoked by uid 1001); 8 Sep 2001 16:36:18 +1000
Message-ID: <nospam-999930978.92645@maxim.gbch.net>
X-Posted-By: GJB-Post 2.21 16-Jun-2001
X-Operating-System: FreeBSD 4.2-RELEASE i386
X-Location: Brisbane, Australia; 27.49841S 152.98439E
X-URL: http://www.gbch.net/gjb.html
X-Image-URL: http://www.gbch.net/gjb/gjb-auug048.gif
X-GPG-Fingerprint: EBB2 2A92 A79D 1533 AC00  3C46 5D83 B6FB 4B04 B7D6
X-PGP-Public-Keys: http://www.gbch.net/keys.html
Date: Sat, 08 Sep 2001 16:36:18 +1000
From: Greg Black <gjb@gbch.net>
To: obrien@freebsd.org
Cc: Bill Swingle <unfurl@dub.net>,
	FreeBSD Hackers <hackers@freebsd.org>
Subject: Re: tiny patch to pkg_add 
References: <20010907150416.A38565@dub.net> <20010907162242.A16949@dragon.nuxi.com> 
In-reply-to: <20010907162242.A16949@dragon.nuxi.com> 
	of Fri, 07 Sep 2001 16:22:43 MST
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG

"David O'Brien" wrote:

| On Fri, Sep 07, 2001 at 03:04:16PM -0700, Bill Swingle wrote:
| > So this represents my most significant effort to date to fix something
| > in C. It took me far too long to identify where the one line fix needed
| > to go and even longer to figure out how to do it in C. 
| > 
| > Here's the problem that this fixes:
| 
| This was introduced in rev 1.38:
| 
|     and replace a big if..then..else construct
|     to determine the package download directory with a lookup table.
| 
| I am very tempted to back this part out.  This "better implimentation"
| has now had two logic bugs.  I wrote that "big if..then..else contstruct"
| so that the code would be *so* simple my simple my 1st quarter freshman
| students (back when I TA'ed) could understand it.  I did it that way
| because I got tired of committers constantly breaking -r.

Simple and correct is always better than clever and wrong.  I'd
be strongly in favour of backing it out.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message