From owner-freebsd-ports-bugs@freebsd.org Wed Mar 23 11:18:08 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 639A1ADAB06 for ; Wed, 23 Mar 2016 11:18:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 42AEE1C4B for ; Wed, 23 Mar 2016 11:18:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u2NBI8gV073156 for ; Wed, 23 Mar 2016 11:18:08 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 207929] [NEW PORT] biology/jellyfish: Fast, memory-efficient counting of k-mers in DNA Date: Wed, 23 Mar 2016 11:18:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rakuco@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 11:18:08 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207929 Raphael Kubo da Costa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rakuco@FreeBSD.org --- Comment #2 from Raphael Kubo da Costa --- Some suggestions after a quick review: * You can drop the pkg-config sed call and replace it with USES=3Dpathfix a= nd PATHFIX_MAKEFILEIN=3DMakefile.am. * The version and architecture checks can be simplified: 1. Use a helper to mark the port as broken: BROKEN_FreeBSD_9_i386=3D multiple code issues on i386 < 10.0-RELEASE 2. Use MACHINE_CPU to check if the CPU supports SSE: .if empty(MACHINE_CPU:sse) CONFIGURE_ARGS+=3D --without-sse .endif This also allows you to just include bsd.port.mk. * BUILD_DEPENDS+=3D should be BUILD_DEPENDS=3D * Should --without-sse work on amd64? I tried passing it here and the build failed. --=20 You are receiving this mail because: You are the assignee for the bug.=