From owner-freebsd-stable@FreeBSD.ORG Thu May 29 08:36:54 2014 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 48546E1A; Thu, 29 May 2014 08:36:54 +0000 (UTC) Received: from ns.kevlo.org (220-135-115-6.HINET-IP.hinet.net [220.135.115.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "ns.kevlo.org", Issuer "ns.kevlo.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id EEAE12DBA; Thu, 29 May 2014 08:36:53 +0000 (UTC) Received: from ns.kevlo.org (localhost [127.0.0.1]) by ns.kevlo.org (8.14.8/8.14.8) with ESMTP id s4T8aK4B008445 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 29 May 2014 16:36:21 +0800 (CST) (envelope-from kevlo@ns.kevlo.org) Received: (from kevlo@localhost) by ns.kevlo.org (8.14.8/8.14.8/Submit) id s4T8aJiH008444; Thu, 29 May 2014 16:36:19 +0800 (CST) (envelope-from kevlo) Date: Thu, 29 May 2014 16:36:19 +0800 From: Kevin Lo To: Jason Hellenthal Subject: Re: [VIMAGE][udplite] FreeBSD 10-STABLE/powerpc Message-ID: <20140529083619.GA8437@ns.kevlo.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) Cc: "freebsd-net@freebsd.org" , adrian@freebsd.org, Gleb Smirnoff , "\[FreeBSD Stable\]" , jhb@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 May 2014 08:36:54 -0000 On Thu, May 29, 2014 at 02:34:47AM -0400, Jason Hellenthal wrote: > Is anyone aware that VIMAGE on powerpc is currently broken ? Hi Jason, Did you mean that compile VIMAGE support into your kernel will fail? If so, what compiler do you use? Thanks. > > In file included from /export/usr/src/sys/netinet/in_proto.c:83: > /export/usr/src/sys/netinet/udp_var.h: In function 'get_inpcbinfo': > /export/usr/src/sys/netinet/udp_var.h:153: error: dereferencing pointer to > incomplete type > /export/usr/src/sys/netinet/udp_var.h:153: error: dereferencing pointer to > incomplete type > /export/usr/src/sys/netinet/udp_var.h: In function 'get_pcblist': > /export/usr/src/sys/netinet/udp_var.h:159: error: dereferencing pointer to > incomplete type > /export/usr/src/sys/netinet/udp_var.h:159: error: dereferencing pointer to > incomplete type > *** Error code 1 > > The relevant code in that header is: > get_inpcbinfo(uint8_t protocol) > { > return (protocol == IPPROTO_UDP) ? &V_udbinfo : &V_ulitecbinfo; > } > > get_pcblist(uint8_t protocol) > { > return (protocol == IPPROTO_UDP) ? &V_udb : &V_ulitecb; > } > > Working Copy Root Path: /usr/src > URL: svn://svn.freebsd.org/base/stable/10 > Relative URL: ^/stable/10 > Repository Root: svn://svn.freebsd.org/base > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > Revision: 266818 > Node Kind: directory > Schedule: normal > Last Changed Author: delphij > Last Changed Rev: 266816 > Last Changed Date: 2014-05-28 14:51:49 -0400 (Wed, 28 May 2014) > > Also looking at svn it appears to have come from this commit... I have > backed out the change here and it appears to be following through so more > attention to VIMAGE and udplite seems to be needed. > > ------------------------------------------------------------------------ > r265946 | kevlo | 2014-05-13 02:05:53 -0400 (Tue, 13 May 2014) | 14 lines > Changed paths: > M /stable/10 > M /stable/10/lib/libc/net/getaddrinfo.c > M /stable/10/sys/netinet/in.c > M /stable/10/sys/netinet/in.h > M /stable/10/sys/netinet/in_pcb.c > M /stable/10/sys/netinet/in_proto.c > M /stable/10/sys/netinet/udp_usrreq.c > M /stable/10/sys/netinet/udp_var.h > A /stable/10/sys/netinet/udplite.h (from > /head/sys/netinet/udplite.h:264212) > M /stable/10/sys/netinet6/in6_ifattach.c > M /stable/10/sys/netinet6/in6_proto.c > M /stable/10/sys/netinet6/udp6_usrreq.c > M /stable/10/sys/netinet6/udp6_var.h > M /stable/10/sys/sys/param.h > > MFC r264212,r264213,r264248,r265776,r265811,r265909: > > - Add support for UDP-Lite protocol (RFC 3828) to IPv4 and IPv6 stacks. > Tested with vlc and a test suite [1]. > [1] http://www.erg.abdn.ac.uk/~gerrit/udp-lite/files/udplite_linux.tar.gz > > Reviewed by: jhb, glebius, adrian > > - Fix a logic bug which prevented the sending of UDP packet with 0 checksum. > > - Disable TX checksum offload for UDP-Lite completely. It wasn't used for > partial checksum coverage, but even for full checksum coverage it doesn't > work. > > ------------------------------------------------------------------------ Kevin