From owner-freebsd-current Sat Jan 27 12:48:58 2001 Delivered-To: freebsd-current@freebsd.org Received: from feral.com (feral.com [192.67.166.1]) by hub.freebsd.org (Postfix) with ESMTP id 8AF5637B400 for ; Sat, 27 Jan 2001 12:48:41 -0800 (PST) Received: from zeppo.feral.com (IDENT:mjacob@zeppo [192.67.166.71]) by feral.com (8.9.3/8.9.3) with ESMTP id MAA31397; Sat, 27 Jan 2001 12:48:37 -0800 Date: Sat, 27 Jan 2001 12:48:36 -0800 (PST) From: Matthew Jacob Reply-To: mjacob@feral.com To: Jason Evans Cc: Dag-Erling Smorgrav , freebsd-current@FreeBSD.ORG Subject: Re: XXX driver didn't initialize queue mtx In-Reply-To: <20010127124149.O87569@canonware.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Shouldn't ether_ifattach initialize the mutex? Or do expect all drivers to initialize these prior to calling ether_ifattach? Look- I just want to know what the people who put the check in *want*..... > On Sat, Jan 27, 2001 at 12:36:41PM -0800, Matthew Jacob wrote: > > > > Oh, I suppose, I did find that... well, mainly I wanted the person who made > > the change to actually broadcast to NIC maintainers what the expectations > > were... > > The code that prints these warnings out has existed for a while. However, > whoever added it made a bad assumption about the internals of the mutex > implementation, so the code never got executed. I "fixed" it last week, so > the warnings get printed now. > > Jason > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message