From owner-svn-src-all@FreeBSD.ORG Sun Aug 18 13:27:05 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 1857CB93; Sun, 18 Aug 2013 13:27:05 +0000 (UTC) (envelope-from jilles@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 051252768; Sun, 18 Aug 2013 13:27:05 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r7IDR4qZ051795; Sun, 18 Aug 2013 13:27:04 GMT (envelope-from jilles@svn.freebsd.org) Received: (from jilles@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id r7IDR4Xg051791; Sun, 18 Aug 2013 13:27:04 GMT (envelope-from jilles@svn.freebsd.org) Message-Id: <201308181327.r7IDR4Xg051791@svn.freebsd.org> From: Jilles Tjoelker Date: Sun, 18 Aug 2013 13:27:04 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r254489 - head/sys/kern X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Aug 2013 13:27:05 -0000 Author: jilles Date: Sun Aug 18 13:27:04 2013 New Revision: 254489 URL: http://svnweb.freebsd.org/changeset/base/254489 Log: Disallow opening a POSIX message queue for execute. O_EXEC was formerly ignored, so equivalent to O_RDONLY. Reject O_EXEC with [EINVAL] like the invalid mode 3. Modified: head/sys/kern/uipc_mqueue.c Modified: head/sys/kern/uipc_mqueue.c ============================================================================== --- head/sys/kern/uipc_mqueue.c Sun Aug 18 13:25:18 2013 (r254488) +++ head/sys/kern/uipc_mqueue.c Sun Aug 18 13:27:04 2013 (r254489) @@ -2046,7 +2046,7 @@ sys_kmq_open(struct thread *td, struct k struct mq_attr attr; int flags, error; - if ((uap->flags & O_ACCMODE) == O_ACCMODE) + if ((uap->flags & O_ACCMODE) == O_ACCMODE || uap->flags & O_EXEC) return (EINVAL); flags = FFLAGS(uap->flags); if ((flags & O_CREAT) != 0 && uap->attr != NULL) { @@ -2682,7 +2682,7 @@ freebsd32_kmq_open(struct thread *td, st struct mq_attr32 attr32; int flags, error; - if ((uap->flags & O_ACCMODE) == O_ACCMODE) + if ((uap->flags & O_ACCMODE) == O_ACCMODE || uap->flags & O_EXEC) return (EINVAL); flags = FFLAGS(uap->flags); if ((flags & O_CREAT) != 0 && uap->attr != NULL) {