From owner-freebsd-ports@FreeBSD.ORG Wed Feb 12 08:08:57 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 83816BD0 for ; Wed, 12 Feb 2014 08:08:57 +0000 (UTC) Received: from ben.at.xencon.de (ben.sh [83.246.72.210]) by mx1.freebsd.org (Postfix) with ESMTP id 3E3381376 for ; Wed, 12 Feb 2014 08:08:56 +0000 (UTC) Received: from localhost (aftr-37-24-157-236.unity-media.net [37.24.157.236]) by ben.at.xencon.de (Postfix) with ESMTPSA id D0CE13A2576 for ; Wed, 12 Feb 2014 09:08:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=darklajid.de; s=default; t=1392192528; bh=H6et1ljDZdZICL0H5qbZVLSPoF1rQXYqfCTdKU5UZak=; h=From:To:Subject:Date:In-Reply-To:References; b=g/lnXL7WRD/2DfOjS8IjAK/lFr2gLp9rIa6GPgBu33AcY9kgWdoCHJ5R8ldfPcUA1 iHqvfLOp22tXRgfcwTuvPq1npBgYuMNoIrO9NkkWbrktpm1GEVVuhZ8wDk77f5He+8 UlF0gFFtmYzxt0C71HcwZaDm2LiaxzS/C/9BEHDA= From: Benjamin Podszun To: Subject: Re: dovecot, init script - is this expected or PR =?iso-8859-1?Q?worthy=3F?= Date: Wed, 12 Feb 2014 09:08:47 +0100 User-Agent: trojita/v0.3.93-272-g6b1b2aa; Qt/4.8.5; X11; Linux; Arch Linux MIME-Version: 1.0 Message-ID: <05e8cdca-8e86-4570-bbba-054433e401c8@darklajid.de> In-Reply-To: References: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Feb 2014 08:08:57 -0000 On Wednesday, February 12, 2014 2:56:18 AM CEST, Stephen R Guglielmo wrote: > On Tue, Feb 11, 2014 at 12:24 PM, Benjamin Podszun < > benjamin.podszun@gmail.com> wrote: > >> service dovecot start >>=20 >> and .. that succeeds always, if dovecot_enable=3D"YES" is missing (which >> totally is an error on my part, obviously). >>=20 >> What I expect though is the typical "Can't do that, Dave. Try onestart >> perhaps" response - and some exit code that signals failure. >>=20 > > >> Is that a (tiny, minor) bug? Should I submit a PR for that? Or is that >> totally irrelevant and people out there would never fall for=20 >> that anyway..? >>=20 >> Thanks, >> Ben >>=20 > > Hey, > > I can't reproduce this on my system. I typically run the rc.d/ scripts > myself, but I did try using the `service` command as well. It works as > expected: The script returns no output when dovecot_enable is commented > out or set equal to NO in my /etc/rc.conf.local file, and it does not=20 start > or stop the dovecot processes. > > I'm using dovecot 1.2.17 on 10.0-RELEASE. Are you using dovecot 2? Hi. I .. think my mail was probably too convoluted and messy. My point? service foo start shouldn't be silent if the service isn't starting. The=20 default rc functions ensure that, give the 'Need foo_enable or onestart=20 instead' message. Dovecot's rc script doesn't, because it doesn't even=20 _invoke_ the rc functions if dovecot_enable !=3D YES. (dovecot2 for me, btw - but you described seeing exactly what I see:=20 Nothing, but the service isn't starting either) The whole point is that this silently fails. Is that okay? Regards, Ben