From owner-svn-src-all@FreeBSD.ORG Sun Dec 14 15:11:31 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E32158BF; Sun, 14 Dec 2014 15:11:31 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9A21E77B; Sun, 14 Dec 2014 15:11:31 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::ec02:9330:f41e:f824] (unknown [IPv6:2001:7b8:3a7:0:ec02:9330:f41e:f824]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 56967B80A; Sun, 14 Dec 2014 16:11:17 +0100 (CET) Subject: Re: svn commit: r275742 - in stable: 10/contrib/llvm/lib/Transforms/Vectorize 10/sys/sys 9/contrib/llvm/lib/Transforms/Vectorize 9/sys/sys Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Content-Type: multipart/signed; boundary="Apple-Mail=_11473C2F-6908-4332-8B72-2C7072FDDD52"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b3 From: Dimitry Andric In-Reply-To: <548DA4A3.8020000@freebsd.org> Date: Sun, 14 Dec 2014 16:11:09 +0100 Message-Id: <43A88D44-A799-46AB-8853-560407BABC84@FreeBSD.org> References: <201412131214.sBDCESwJ033037@svn.freebsd.org> <548DA4A3.8020000@freebsd.org> To: Steven Hartland X-Mailer: Apple Mail (2.1993) Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-10@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Dec 2014 15:11:32 -0000 --Apple-Mail=_11473C2F-6908-4332-8B72-2C7072FDDD52 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 14 Dec 2014, at 15:54, Steven Hartland = wrote: >=20 > On 13/12/2014 12:14, Dimitry Andric wrote: >> Author: dim >> Date: Sat Dec 13 12:14:26 2014 >> New Revision: 275742 >> URL: https://svnweb.freebsd.org/changeset/base/275742 >>=20 >> Log: >> MFC r275633: >> Pull in r223171 from upstream llvm trunk (by Michael = Zolotukhin): >> PR21302. Vectorize only bottom-tested loops. >> rdar://problem/18886083 >> This fixes a bug in the llvm vectorizer, which could sometimes = cause >> vectorized loops to perform an additional iteration, leading to = possible >> buffer overruns. Symptoms of this, which are usually segfaults, = were >> first noticed when building gcc ports, here: >> = https://lists.freebsd.org/pipermail/freebsd-ports/2014-September/095466.ht= ml >> = https://lists.freebsd.org/pipermail/freebsd-toolchain/2014-September/00121= 1.html >> Since this fix is very important for ports, bump = __FreeBSD_version to >> make it easier for port maintainers to test whether the fix has = been >> applied. >> Upstream PR: http://llvm.org/PR21302 >=20 > Sounds nasty, is this something that only effects stable/10 or does it = also effects 10.1-RELEASE? Yes, this is quite nasty, and it does affect 10.1-RELEASE, 9.3-RELEASE, and any other release with clang 3.4.x, which turned on the vectorizer by default. Although it is in fact rather hard to create the situation where it can possibly do an off-by-one, I would really advise to apply this diff to release systems as well. I also contacted secteam@ about it, but apparently they have not yet decided whether to do a security advisory for this bug. -Dimitry --Apple-Mail=_11473C2F-6908-4332-8B72-2C7072FDDD52 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.26 iEYEARECAAYFAlSNqJUACgkQsF6jCi4glqNu4QCfUAG/IKnCl61Lz557s4NHDmId WuQAoMw6P5IekLs/uJ55PgziVWKTTwfs =4Yf+ -----END PGP SIGNATURE----- --Apple-Mail=_11473C2F-6908-4332-8B72-2C7072FDDD52--