From owner-svn-src-head@FreeBSD.ORG  Thu Mar  7 23:00:52 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id ED05CF48;
 Thu,  7 Mar 2013 23:00:52 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (tensor.andric.com
 [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26])
 by mx1.freebsd.org (Postfix) with ESMTP id AD0A495C;
 Thu,  7 Mar 2013 23:00:52 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7:0:204:4bff:fe01:de8a] (spaceball.andric.com
 [IPv6:2001:7b8:3a7:0:204:4bff:fe01:de8a])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id 9B5655C44;
 Fri,  8 Mar 2013 00:00:45 +0100 (CET)
Message-ID: <51391C1E.5030905@FreeBSD.org>
Date: Fri, 08 Mar 2013 00:00:46 +0100
From: Dimitry Andric <dim@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:19.0) Gecko/20130117 Thunderbird/19.0
MIME-Version: 1.0
To: Andriy Gapon <avg@FreeBSD.org>
Subject: Re: svn commit: r247960 - head/cddl/contrib/opensolaris/tools/ctf/cvt
References: <201303072216.r27MGZ1b031061@svn.freebsd.org>
 <513914C4.4010001@FreeBSD.org>
In-Reply-To: <513914C4.4010001@FreeBSD.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Mar 2013 23:00:53 -0000

On 2013-03-07 23:29, Andriy Gapon wrote:
...
> I was not really kidding when I said that this change, as is, is a nop:
...
>> +			bname = strrchr(match.iim_name, '/');
>> +			bname = bname == NULL ? match.iim_name : bname + 1;
>
> It would probably make sense to make use of bname after going to through all the
> trouble of calculating it:
>
>>   			match.iim_file = match.iim_name;
>
> Should be match.iim_file = bname ?

Yes, I actually had this in my test code, and committed the wrong diff
by accident. :(  Fixed in r247962, in any case.


> Surprised that clang hasn't warned you about this one :-)

Clang currently does not have the -Wunused-but-set-variable warning; it
is apparently available in the static analyzer.  On the other hand, that
warning is one of the most annoying ones that newer gcc's have. :-)